feat(compiler): handle nested container ref pointer options in C++ compiler correctly#3735
Merged
Merged
Conversation
chaokunyang
reviewed
Jun 9, 2026
| in cpp_output | ||
| ) | ||
| assert ( | ||
| "std::map<std::string, " |
Collaborator
There was a problem hiding this comment.
C++ should use unorderd_map, could you open a new pr for this?
Contributor
Author
There was a problem hiding this comment.
No problem, working on it
BaldDemian
force-pushed
the
cpp-nested-container
branch
from
fc1ace7 to
c1f2c96
Compare
chaokunyang
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The C++ compiler should correctly apply ref pointer options for nested container element/value references.
Additional note:
When submitting PR 3731, I did not notice that Fory currently only supports nested collection types in C++:
fory/docs/compiler/schema-idl.md
Lines 1414 to 1418 in 33b0d6e
However, since that PR merely added a piece of defensive programming logic, it may not need to be reverted.
Similar issues also exist in the Python and JavaScript compilers. However, since they do not support nested container types, I have not fixed them for now.
What does this PR do?
Related issues
N/A.
AI Contribution Checklist
noyes, I included a completed AI Contribution Checklist in this PR description and the requiredAI Usage Disclosure.yes, my PR description includes the requiredai_reviewsummary and screenshot evidence of the final clean AI review results from both fresh reviewers on the current PR diff or current HEAD after the latest code changes.Does this PR introduce any user-facing change?
N/A.
Benchmark
N/A.