Skip to content

Commit 9baab8d

Browse files
Apply suggestions from code review
Co-authored-by: Huaijin <haohuaijin@gmail.com>
1 parent a14a827 commit 9baab8d

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

datafusion/physical-expr/src/utils/guarantee.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -196,11 +196,11 @@ impl LiteralGuarantee {
196196
// if all terms are 'col <op> literal' with the same column
197197
// and operation we can infer any guarantees
198198
//
199-
// For those like (a != bar OR a != baz).
199+
// For those like (a != foo AND (a != bar OR a != baz)).
200200
// We can't combine the (a != bar OR a != baz) part, but
201201
// it also doesn't invalidate our knowledge that a !=
202202
// foo is required for the expression to be true.
203-
// So we can only create a multi guarantee for `=`
203+
// So we can only create a multi value guarantee for `=`
204204
// (or a single value). (e.g. ignore `a != foo OR a != bar`)
205205
let first_term = &terms[0];
206206
if terms.iter().all(|term| {
@@ -773,7 +773,7 @@ mod test {
773773
.and(col("b").eq(lit(4)).or(col("b").eq(lit(5)))),
774774
vec![],
775775
);
776-
// b not in (1, 2, 3) AND (b = 3 OR b = 4)
776+
// b NOT IN (1, 2, 3) AND (b = 3 OR b = 4)
777777
test_analyze(
778778
col("b")
779779
.in_list(vec![lit(1), lit(2), lit(3)], true)

0 commit comments

Comments
 (0)