Implement TreeNode::map_children in place

Author: alamb

datafusion/expr/src/logical_plan/plan.rs

@@ -22,27 +22,9 @@ use std::fmt::{self, Debug, Display, Formatter};
 use std::hash::{Hash, Hasher};
 use std::sync::Arc;
 
-use super::dml::CopyTo;
-use super::DdlStatement;
-use crate::builder::change_redundant_column;
-use crate::expr::{
-    Alias, Exists, InSubquery, Placeholder, Sort as SortExpr, WindowFunction,
-};
-use crate::expr_rewriter::{create_col_from_scalar_expr, normalize_cols};
-use crate::logical_plan::display::{GraphvizVisitor, IndentVisitor};
-use crate::logical_plan::extension::UserDefinedLogicalNode;
-use crate::logical_plan::{DmlStatement, Statement};
-use crate::utils::{
-    enumerate_grouping_sets, exprlist_to_fields, find_out_reference_exprs,
-    grouping_set_expr_count, grouping_set_to_exprlist, split_conjunction,
-};
-use crate::{
-    build_join_schema, expr_vec_fmt, BinaryExpr, BuiltInWindowFunction,
-    CreateMemoryTable, CreateView, Expr, ExprSchemable, LogicalPlanBuilder, Operator,
-    TableProviderFilterPushDown, TableSource, WindowFunctionDefinition,
-};
-
 use arrow::datatypes::{DataType, Field, Schema, SchemaRef};
+
+pub use datafusion_common::display::{PlanType, StringifiedPlan, ToStringifiedPlan};
 use datafusion_common::tree_node::{
     Transformed, TransformedResult, TreeNode, TreeNodeIterator, TreeNodeRecursion,
     TreeNodeRewriter, TreeNodeVisitor,
@@ -53,12 +35,31 @@ use datafusion_common::{
     FunctionalDependence, FunctionalDependencies, ParamValues, Result, TableReference,
     UnnestOptions,
 };
+pub use datafusion_common::{JoinConstraint, JoinType};
 
+use crate::builder::change_redundant_column;
+use crate::{
+    build_join_schema, expr_vec_fmt, BinaryExpr, BuiltInWindowFunction,
+    CreateMemoryTable, CreateView, Expr, ExprSchemable, LogicalPlanBuilder, Operator,
+    TableProviderFilterPushDown, TableSource, WindowFunctionDefinition,
+};
 // backwards compatibility
 use crate::display::PgJsonVisitor;
+use crate::expr::{
+    Alias, Exists, InSubquery, Placeholder, Sort as SortExpr, WindowFunction,
+};
+use crate::expr_rewriter::{create_col_from_scalar_expr, normalize_cols};
+use crate::logical_plan::display::{GraphvizVisitor, IndentVisitor};
+use crate::logical_plan::extension::UserDefinedLogicalNode;
+use crate::logical_plan::{DmlStatement, Statement};
 use crate::tree_node::transform_option_vec;
-pub use datafusion_common::display::{PlanType, StringifiedPlan, ToStringifiedPlan};
-pub use datafusion_common::{JoinConstraint, JoinType};
+use crate::utils::{
+    enumerate_grouping_sets, exprlist_to_fields, find_out_reference_exprs,
+    grouping_set_expr_count, grouping_set_to_exprlist, split_conjunction,
+};
+
+use super::dml::CopyTo;
+use super::DdlStatement;
 
 /// A LogicalPlan represents the different types of relational
 /// operators (such as Projection, Filter, etc) and can be created by
@@ -3039,17 +3040,19 @@ pub struct Unnest {
 mod tests {
     use std::sync::Arc;
 
-    use super::*;
-    use crate::builder::LogicalTableSource;
-    use crate::logical_plan::table_scan;
-    use crate::{col, count, exists, in_subquery, lit, placeholder, GroupingSet};
-
     use arrow::datatypes::{DataType, Field, Schema};
+
     use datafusion_common::tree_node::TreeNodeVisitor;
     use datafusion_common::{
         not_impl_err, Constraint, DFSchema, ScalarValue, TableReference,
     };
 
+    use crate::builder::LogicalTableSource;
+    use crate::logical_plan::table_scan;
+    use crate::{col, count, exists, in_subquery, lit, placeholder, GroupingSet};
+
+    use super::*;
+
     fn employee_schema() -> Schema {
         Schema::new(vec![
             Field::new("id", DataType::Int32, false),