Skip to content

Commit d39d22b

Browse files
committed
Fixing auth issue for ad related mosdules using service principal (#537)
* fixing ad related auth issue when using service pricinpal.
1 parent b29193f commit d39d22b

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

plugins/module_utils/azure_rm_common.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1427,19 +1427,20 @@ def __init__(self, auth_source=None, profile=None, subscription_id=None, client_
14271427
else:
14281428
self._adfs_authority_url = self.credentials.get('adfs_authority_url')
14291429

1430-
# get resource from cloud environment
1431-
self._resource = self._cloud_environment.endpoints.active_directory_resource_id
1432-
14331430
if self.credentials.get('credentials') is not None:
14341431
# AzureCLI credentials
14351432
self.azure_credentials = self.credentials['credentials']
14361433
elif self.credentials.get('client_id') is not None and \
14371434
self.credentials.get('secret') is not None and \
14381435
self.credentials.get('tenant') is not None:
1436+
1437+
graph_resource = self._cloud_environment.endpoints.active_directory_graph_resource_id
1438+
rm_resource = self._cloud_environment.endpoints.resource_manager
14391439
self.azure_credentials = ServicePrincipalCredentials(client_id=self.credentials['client_id'],
14401440
secret=self.credentials['secret'],
14411441
tenant=self.credentials['tenant'],
14421442
cloud_environment=self._cloud_environment,
1443+
resource=graph_resource if self.is_ad_resource else rm_resource,
14431444
verify=self._cert_validation_mode == 'validate')
14441445

14451446
elif self.credentials.get('ad_user') is not None and \
@@ -1449,7 +1450,7 @@ def __init__(self, auth_source=None, profile=None, subscription_id=None, client_
14491450

14501451
self.azure_credentials = self.acquire_token_with_username_password(
14511452
self._adfs_authority_url,
1452-
self._resource,
1453+
self._cloud_environment.endpoints.active_directory_resource_id,
14531454
self.credentials['ad_user'],
14541455
self.credentials['password'],
14551456
self.credentials['client_id'],

0 commit comments

Comments
 (0)