fix(desktop): use server-side picker for all HTTP connections

Native OS file picker was shown when Desktop connected to a remote server
via localhost port forwarding (e.g. ssh -L 4096:localhost:4096 linux-host).
The localhost URL caused ServerConnection.local() to return true, triggering
the native Electron dialog. A Windows path (e.g. D:\\renpy-workspace) was
then sent to the remote Linux server, which rejected it as non-absolute.

Fix: replace ServerConnection.local with ServerConnection.builtin in the
picker policy. Only the embedded sidecar process is guaranteed to share the
OS with the Desktop app. All HTTP connections — including localhost — use
the server-side DialogSelectDirectory.

Author: zhizhizheng

packages/app/src/components/directory-picker-policy.ts

@@ -2,6 +2,6 @@ import { ServerConnection } from "@/context/server"
 import type { Platform } from "@/context/platform"
 
 export function directoryPickerKind(platform: Platform["platform"], server: ServerConnection.Any) {
-  if (platform === "desktop" && ServerConnection.local(server)) return "native" as const
+  if (platform === "desktop" && ServerConnection.builtin(server)) return "native" as const
   return "server" as const
 }

packages/app/src/components/directory-picker.test.ts

@@ -1,21 +1,50 @@
 import { describe, expect, test } from "bun:test"
 import { directoryPickerKind } from "./directory-picker-policy"
 
-const local = {
+const sidecar = {
   type: "sidecar",
   variant: "base",
   http: { url: "http://localhost:4096" },
 } as const
-const remote = {
+
+const wsl = {
+  type: "sidecar",
+  variant: "wsl",
+  distro: "Ubuntu",
+  http: { url: "http://localhost:4097" },
+} as const
+
+const httpLocalhost = {
+  type: "http",
+  http: { url: "http://localhost:4096" },
+} as const
+
+const httpRemote = {
+  type: "http",
+  http: { url: "http://192.168.1.100:4096" },
+} as const
+
+const ssh = {
   type: "ssh",
   host: "example.test",
   http: { url: "http://localhost:4096" },
 } as const
 
 describe("directoryPickerKind", () => {
-  test("uses the native picker only for local desktop projects", () => {
-    expect(directoryPickerKind("desktop", local)).toBe("native")
-    expect(directoryPickerKind("desktop", remote)).toBe("server")
-    expect(directoryPickerKind("web", local)).toBe("server")
+  test("uses the native picker only for the built-in sidecar", () => {
+    // Only the embedded sidecar process is guaranteed to share the OS with the Desktop app
+    expect(directoryPickerKind("desktop", sidecar)).toBe("native")
+
+    // All HTTP connections use the server-side picker — a localhost URL could be a
+    // port-forwarded remote server (e.g. Linux behind SSH tunnel from Windows)
+    expect(directoryPickerKind("desktop", httpLocalhost)).toBe("server")
+    expect(directoryPickerKind("desktop", httpRemote)).toBe("server")
+
+    // WSL and SSH are always remote filesystems
+    expect(directoryPickerKind("desktop", wsl)).toBe("server")
+    expect(directoryPickerKind("desktop", ssh)).toBe("server")
+
+    // Web platform never has access to the native picker
+    expect(directoryPickerKind("web", sidecar)).toBe("server")
   })
 })