fix(hook): hook is not being triggered on Mac OS X

* fix(hook): hook is not being triggered on `Mac OS X`

* chore(hook): remove redundant shebang

* feat(tslint): updated to 5.x

* chore(packages): bump `@speedy/node-core`

Author: alan-agius4

README.md

@@ -17,8 +17,6 @@ Commit first line format:
 npm install @speedy/commit-msg-hook --save-dev
 ```
 
-Note: for Windows users, you might need to be install the package in `Administrator` mode. As on Windows only users with `SeCreateSymbolicLinkPrivilege` can create `Symbolic Links`, which is granted only to administrators by default.
-
 ## Rules
 
 The majority of the rules can be applied in any part of the configuration.

package.json

@@ -32,10 +32,10 @@
     "preversion": "npm test",
     "version": "npm run build && npm run changelog",
     "postversion": "git commit --all -m \"chore(all): update for release\" && git push && git push --tags",
-    "release": "ts-node ./tools/modify-package && npm publish && git checkout ."
-  },
+    "release": "ts-node ./tools/modify-package ",
+    "install": "node ./dist/installer install"},
   "dependencies": {
-    "@speedy/node-core": "^1.0.0",
+    "@speedy/node-core": "^1.0.1",
     "lodash": "^4.17.4"
   },
   "devDependencies": {
@@ -48,7 +48,7 @@
     "mock-fs": "^4.2.0",
     "rimraf": "^2.6.1",
     "ts-node": "^3.0.2",
-    "tslint": "^4.5.1",
+    "tslint": "^5.0.0",
     "typescript": "^2.2.0"
   },
   "typings": "dist/index.d.ts"

src/hook.ts

@@ -1,5 +1,3 @@
-#!/usr/bin/env node
-
 import { validator } from "./validator";
 
 validator

src/installer.ts

@@ -1,4 +1,4 @@
-import { mkdirSync, lstatSync, Stats, renameSync, unlinkSync, symlinkSync, existsSync } from "fs";
+import { mkdirSync, lstatSync, Stats, renameSync, constants, unlinkSync, writeFileSync, existsSync } from "fs";
 import { join } from "path";
 import { fileSystem } from "@speedy/node-core";
 
@@ -27,20 +27,23 @@ if (process.argv[2] === "uninstall") {
 
 function install() {
 	if (existsSync(hooksPath)) {
-		uninstall();
-
 		if (fileStat && fileStat.isFile()) {
 			renameSync(commitMsgHookPath, `${commitMsgHookPath}.backup`);
+		} else {
+			uninstall();
 		}
 	} else {
 		mkdirSync(hooksPath);
 	}
 
-	symlinkSync(join(__dirname, "hook.js"), commitMsgHookPath);
+	const hookContent = `#!/usr/bin/env node
+						require("${join(__dirname, "hook.js")}");`;
+
+	writeFileSync(commitMsgHookPath, hookContent, { mode: constants.S_IRWXU });
 }
 
 function uninstall() {
-	if (fileStat && fileStat.isSymbolicLink()) {
+	if (fileStat) {
 		unlinkSync(commitMsgHookPath);
 	}
 }

src/validator/validator.ts

@@ -12,7 +12,7 @@ export namespace validator {
 	export async function validate(commitMessage?: string, configFilePath?: string) {
 		const configPath = config.getConfigFilePath(
 			configFilePath || DEFAULT_CONFIG_FILENAME,
-			join(__dirname, "../../config", DEFAULT_CONFIG_FILENAME)
+			join(__dirname, "../../config")
 		);
 		const configData = await config.readConfigFile<ConfigData>(configPath);
 		const { type, message, scope, subject } = configData.rules;

tsconfig.json

@@ -8,6 +8,8 @@
 		"declaration": true,
 		"noImplicitReturns": true,
 		"noImplicitAny": true,
+		"noUnusedLocals": true,
+		"noUnusedParameters": true,
 		"noFallthroughCasesInSwitch": true,
 		"allowUnreachableCode": false,
 		"skipLibCheck": true,

tslint.json

@@ -31,6 +31,10 @@
 			true,
 			140
 		],
+		"member-access": [
+			true,
+			"no-public"
+		],
 		"member-ordering": [
 			true,
 			{
@@ -78,16 +82,9 @@
 		"no-string-throw": true,
 		"no-switch-case-fall-through": false,
 		"no-trailing-whitespace": true,
+		"no-unnecessary-callback-wrapper": true,
 		"no-unnecessary-initializer": true,
 		"no-unused-expression": true,
-		"no-unused-variable": [
-			true,
-			{
-				"ignore-pattern": "^_"
-			},
-			"check-parameters"
-		],
-		"no-use-before-declare": true,
 		"no-var-keyword": true,
 		"object-literal-key-quotes": [
 			true,
@@ -109,6 +106,10 @@
 		],
 		"prefer-const": true,
 		"prefer-for-of": true,
+		"prefer-template": [
+			true,
+			"allow-single-concat"
+		],
 		"quotemark": [
 			true,
 			"double"