feat(auth): add support for refresh tokens - #390
Merged
Conversation
dizco
force-pushed
the
dizco-fix-get-provider
branch
from
April 25, 2018 03:56
5ca9245 to
75162d1
Compare
Collaborator
nnixaa
approved these changes
Apr 26, 2018
Collaborator
|
Thanks again, @dizco. If by any chance you have other ideas we would be happy to discuss 😃 |
Contributor
Author
|
@nnixaa no problem! I'll let you guys know if I think of anything else 😃 I guess the best way moving forward would be to open issues right? |
Collaborator
|
@dizco yes, exactly. Looking forward to it! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Added a way to refresh tokens inside the AuthService. This is not yet hooked anywhere, but it could be hooked inside an interceptor, as I've seen mentionned in #260. Typically, I think the refresh token would be stored in a HttpOnly cookie. This also addresses #362.
I have also fixed #389, which involved changing
private getProvidertoprotected getProvider.Please let me know if I need to change anything!