fix(datapicker): input update issue with reactive forms - #2945
Merged
yggg merged 4 commits intoNov 24, 2021
Conversation
vladsklov
changed the title
vladsklov
force-pushed
the
fix/2030-datapicker_with_filled_reactive_form
branch
from
November 16, 2021 12:06
b4abf75 to
e7e772b
Compare
vladsklov
force-pushed
the
fix/2030-datapicker_with_filled_reactive_form
branch
from
November 17, 2021 13:27
e7e772b to
5cf112d
Compare
yggg
approved these changes
Nov 24, 2021
2 tasks
|
this pull request has some impact on the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Fixes #2030
Move
$initemission of picker component (NbBasePickerComponent) fromAfterViewInittoOnInitto preventExpressionChangedAfterItHasBeenCheckedErrorerror. Emission atOnInitstage is fineinit$subscribers needs it to know when it's safe to read inputs of picker and atOnInitinputs are already set.Fixes #2898
Removes
this.onChange(this.queue)inpicker.init$subscription as it marksFormControlas dirty. It's invalid behavior as we're at the init stage, and the user didn't touch a control.