Skip to content

fix(button): prevent expression changed error on icon button - #2846

Merged
yggg merged 6 commits into
akveo:masterfrom
evtkhvch:2363-fix-button-NG0100
Nov 8, 2021
Merged

fix(button): prevent expression changed error on icon button#2846
yggg merged 6 commits into
akveo:masterfrom
evtkhvch:2363-fix-button-NG0100

Conversation

@evtkhvch

@evtkhvch evtkhvch commented Aug 25, 2021

Copy link
Copy Markdown
Contributor

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Closes #2363

  • fix NG0100 error in NbButton.iconRight

Error description. Error appears in the following case:

  1. You use nbSpinner directive
  2. <button> content contains <nb-icon> only
  3. loading state changes

Example:

<button [nbSpinner]="loading" nbButton>
  <nb-icon icon="star"></nb-icon>
</button>

Problem: NbButton.iconRight has been changed after change detection has completed

@evtkhvch
evtkhvch marked this pull request as ready for review August 25, 2021 15:27
@yggg yggg changed the title fix(base-button): NG0100 Expression has changed after it was checked fix(button): prevent expression changed error on icon button Nov 8, 2021
@yggg
yggg merged commit baee608 into akveo:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants