feat: add support for TypeScript 4.0 - #2523
Merged
Merged
Conversation
Angular schematics has own bundled TS version which is different from locally installed and leads to types incompatibility. CDK utils installed TS.
TypeScript 4 doesn't allow properties inherited from a base class to be overriden as accessors and vice versa.
DeepCode's analysis on #d61480 found:
Top issues
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
Angular schematics has own bundled TS version which is different from locally installed and leads to types incompatibility. CDK utils use installed TS.
CDK added new `_viewRepeater` and `_coalescedStyleScheduler` constructor parameters which is required for proper table rendering.
This tsconfig file is picked up by editors and IDEs so adding path here help to resolve imports in the projects.
As newer version requires higher version of rxjs and it causes incompatibility in Subject type between Nebular and devkit.
In CDK version 10.2.1 `CdkTable` has two new constructor parameters. If user install CDK prior to 10.2.1 there be an error as NbTable passes two new parameters to a super class CdkTable.
DeepCode's analysis: "Function addRootRoute always returns undefined, but it is called here and its return value is used here"
Codecov Report
@@ Coverage Diff @@
## master #2523 +/- ##
=======================================
Coverage 78.92% 78.93%
=======================================
Files 253 253
Lines 7774 7808 +34
Branches 852 855 +3
=======================================
+ Hits 6136 6163 +27
- Misses 1376 1380 +4
- Partials 262 265 +3
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
TypeScript 4 doesn't allow properties inherited from a base class to be overridden as accessors and vice versa.
Closes #2498. Closes #2501.