Skip to content

feat(menu): support more navigation extras - #2420

Merged
yggg merged 3 commits into
akveo:masterfrom
outfoxx:menu_nav_extras
Sep 17, 2020
Merged

feat(menu): support more navigation extras#2420
yggg merged 3 commits into
akveo:masterfrom
outfoxx:menu_nav_extras

Conversation

@kdubb

@kdubb kdubb commented Jun 20, 2020

Copy link
Copy Markdown
Contributor

This includes thequeryParamsHandling & preserveFragment navigation extras options in addition to the already existing options.

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Allows using the mentioned navigation extra parameters from menu item links.
Fixes #1914

This includes the`queryParamsHandling` & `preserveFragment` navigation extras options in addition to the already existing options.
@kdubb

kdubb commented Jun 20, 2020

Copy link
Copy Markdown
Contributor Author

Fixes #1914

@codecov

codecov Bot commented Jun 20, 2020

Copy link
Copy Markdown

Codecov Report

Merging #2420 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2420      +/-   ##
==========================================
- Coverage   78.97%   78.96%   -0.02%     
==========================================
  Files         253      253              
  Lines        7773     7774       +1     
  Branches      852      852              
==========================================
  Hits         6139     6139              
- Misses       1371     1372       +1     
  Partials      263      263              
Impacted Files Coverage Δ
.../framework/theme/components/menu/menu.component.ts 74.77% <ø> (-0.68%) ⬇️
...rc/framework/theme/components/menu/menu.service.ts 86.86% <ø> (ø)

@kdubb kdubb changed the title feat(menu): support more navigatoin extras feat(menu): support more navigation extras Sep 11, 2020
@kdubb

kdubb commented Sep 11, 2020

Copy link
Copy Markdown
Contributor Author

@yggg Can you review and/or merge this? It's quite helpful 😉

@yggg

yggg commented Sep 17, 2020

Copy link
Copy Markdown
Contributor

Thanks for the contribution @kdubb! Could you please check "Allow edits by maintainers" checkmark? You can find it here:
image
I need to merge master into your branch and check the PR with the latest changes from the master branch, but I can't do it without "Allow edits by maintainers" permission.

@kdubb

kdubb commented Sep 17, 2020

Copy link
Copy Markdown
Contributor Author

@yggg I am familiar with the feature but oddly I have no "Allow edits by maintainers" checkbox on this specific PR. Looking into why.

@kdubb

kdubb commented Sep 17, 2020

Copy link
Copy Markdown
Contributor Author

I do not understand why the option is not available; I updated to HEAD of master for you instead.

@yggg
yggg merged commit 03aabfa into akveo:master Sep 17, 2020
@kdubb
kdubb deleted the menu_nav_extras branch September 17, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NbMenuItem: support queryParamsHandling

2 participants