feat(menu): support more navigation extras - #2420
Merged
Merged
Conversation
This includes the`queryParamsHandling` & `preserveFragment` navigation extras options in addition to the already existing options.
Contributor
Author
|
Fixes #1914 |
Codecov Report
@@ Coverage Diff @@
## master #2420 +/- ##
==========================================
- Coverage 78.97% 78.96% -0.02%
==========================================
Files 253 253
Lines 7773 7774 +1
Branches 852 852
==========================================
Hits 6139 6139
- Misses 1371 1372 +1
Partials 263 263
|
Contributor
Author
|
@yggg Can you review and/or merge this? It's quite helpful 😉 |
yggg
approved these changes
Sep 17, 2020
Contributor
|
Thanks for the contribution @kdubb! Could you please check "Allow edits by maintainers" checkmark? You can find it here: |
Contributor
Author
|
@yggg I am familiar with the feature but oddly I have no "Allow edits by maintainers" checkbox on this specific PR. Looking into why. |
Contributor
Author
|
I do not understand why the option is not available; I updated to HEAD of master for you instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This includes the
queryParamsHandling&preserveFragmentnavigation extras options in addition to the already existing options.Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Allows using the mentioned navigation extra parameters from menu item links.
Fixes #1914