feat(calendar): Eva 1.3 - #2120
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2120 +/- ##
=========================================
- Coverage 84.71% 84.62% -0.1%
=========================================
Files 234 237 +3
Lines 8030 8209 +179
Branches 707 738 +31
=========================================
+ Hits 6803 6947 +144
- Misses 1010 1045 +35
Partials 217 217
|
Tibing
requested changes
Dec 9, 2019
View mode component was moved outside of pageable component
Co-Authored-By: Nikita Poltoratsky <n.poltoratsky@akveo.com>
Also extracts cells theming into own file.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Breaking Changes:
NbCalendarHeaderComponentremoved. Along with thatshowHeaderproperty removed from following components:NbBaseCalendarComponentNbCalendarRangeComponentNbCalendarComponentNbBasePickerNbBasePickerComponentmediumandsize-mediumcss classes were removed along withmedium/isMediumproperties from the following classes:NbCalendarDayPickerComponentNbCalendarMonthPickerComponentNbCalendarYearPickerComponentNbBaseCalendarComponentNbCalendarWeekNumberComponentProperties
date,changeMode,isRtlremoved fromNbCalendarPageableNavigationComponentFile
nb-calendar-week-number.componentrenamed tocalendar-week-number.componentYEARS_IN_VIEW, YEARS_IN_ROWconstants removed. UseNbCalendarYearModelServicesgetYearsInViewandgetRowInViewmethods.NbCalendarNavigationComponentreplaced withNbCalendarViewModeComponent.initYearsmethod removed fromNbCalendarYearPickerComponent.calendar-range-cells.tsfile split intocalendar-range-day-cell.component.ts,calendar-range-month-cell.component.tsandcalendar-range-year-cell.component.ts.Following theme properties were removed:
calendar-body-heightcalendar-header-text-colorcalendar-header-text-font-familycalendar-header-title-text-font-sizecalendar-header-title-text-font-weightcalendar-header-title-text-line-heightcalendar-header-sub-title-text-font-sizecalendar-header-sub-title-text-font-weightcalendar-header-sub-title-text-line-heightcalendar-navigation-button-widthcalendar-large-body-heightcalendar-cell-in-range-background-colorcalendar-cell-disabled-background-colordatepicker-text-colordatepicker-arrow-size