Skip to content

feat(calendar): Eva 1.3 - #2120

Merged
yggg merged 34 commits into
akveo:masterfrom
yggg:feat/eva-1.3-calendar
Dec 19, 2019
Merged

feat(calendar): Eva 1.3#2120
yggg merged 34 commits into
akveo:masterfrom
yggg:feat/eva-1.3-calendar

Conversation

@yggg

@yggg yggg commented Dec 4, 2019

Copy link
Copy Markdown
Contributor

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

Breaking Changes:

  • NbCalendarHeaderComponent removed. Along with that showHeader property removed from following components:

    • NbBaseCalendarComponent
    • NbCalendarRangeComponent
    • NbCalendarComponent
    • NbBasePicker
    • NbBasePickerComponent
  • medium and size-medium css classes were removed along with medium/isMedium properties from the following classes:

    • NbCalendarDayPickerComponent
    • NbCalendarMonthPickerComponent
    • NbCalendarYearPickerComponent
    • NbBaseCalendarComponent
    • NbCalendarWeekNumberComponent
  • Properties date, changeMode, isRtl removed from NbCalendarPageableNavigationComponent

  • File nb-calendar-week-number.component renamed to calendar-week-number.component

  • YEARS_IN_VIEW, YEARS_IN_ROW constants removed. Use NbCalendarYearModelServices getYearsInView and getRowInView methods.

  • NbCalendarNavigationComponent replaced with NbCalendarViewModeComponent.

  • initYears method removed from NbCalendarYearPickerComponent.

  • calendar-range-cells.ts file split into calendar-range-day-cell.component.ts, calendar-range-month-cell.component.ts and calendar-range-year-cell.component.ts.

  • Following theme properties were removed:

    • calendar-body-height
    • calendar-header-text-color
    • calendar-header-text-font-family
    • calendar-header-title-text-font-size
    • calendar-header-title-text-font-weight
    • calendar-header-title-text-line-height
    • calendar-header-sub-title-text-font-size
    • calendar-header-sub-title-text-font-weight
    • calendar-header-sub-title-text-line-height
    • calendar-navigation-button-width
    • calendar-large-body-height
    • calendar-cell-in-range-background-color
    • calendar-cell-disabled-background-color
    • datepicker-text-color
    • datepicker-arrow-size

@yggg
yggg requested a review from nnixaa December 4, 2019 10:54
@codecov

codecov Bot commented Dec 6, 2019

Copy link
Copy Markdown

Codecov Report

Merging #2120 into master will decrease coverage by 0.09%.
The diff coverage is 79.93%.

@@            Coverage Diff            @@
##           master    #2120     +/-   ##
=========================================
- Coverage   84.71%   84.62%   -0.1%     
=========================================
  Files         234      237      +3     
  Lines        8030     8209    +179     
  Branches      707      738     +31     
=========================================
+ Hits         6803     6947    +144     
- Misses       1010     1045     +35     
  Partials      217      217
Impacted Files Coverage Δ
...heme/components/datepicker/datepicker.directive.ts 78.99% <ø> (ø) ⬆️
...c/framework/theme/components/calendar-kit/model.ts 100% <ø> (ø) ⬆️
...lendar-day-picker/calendar-day-picker.component.ts 100% <ø> (ø) ⬆️
...nents/datepicker/datepicker-container.component.ts 100% <ø> (ø) ⬆️
...calendar-day-picker/calendar-day-cell.component.ts 94.87% <100%> (+0.75%) ⬆️
src/framework/theme/public_api.ts 100% <100%> (ø) ⬆️
...rk/theme/components/calendar/calendar.component.ts 100% <100%> (ø) ⬆️
...lendar-year-picker/calendar-year-cell.component.ts 94.28% <100%> (+0.95%) ⬆️
...ndar-month-picker/calendar-month-cell.component.ts 94.28% <100%> (+0.95%) ⬆️
...lendar-kit/services/calendar-year-model.service.ts 100% <100%> (ø)
... and 26 more

@yggg yggg added this to the 5.0.0 milestone Dec 6, 2019
Comment thread src/framework/theme/components/calendar/base-calendar.component.ts Outdated
Comment thread src/framework/theme/components/calendar/base-calendar.component.ts
Comment thread src/framework/theme/components/calendar/base-calendar.component.ts
Comment thread src/framework/theme/components/calendar/calendar-range-cells.ts Outdated
@yggg
yggg removed the request for review from nnixaa December 9, 2019 09:16

@Tibing Tibing left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yggg
yggg merged commit 0f03fb5 into akveo:master Dec 19, 2019
@yggg
yggg deleted the feat/eva-1.3-calendar branch December 19, 2019 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants