fix(sidebar): emit expand event when expanded because of menu click - #1897
Merged
yggg merged 2 commits intoOct 14, 2019
Merged
Conversation
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #1897 +/- ##
==========================================
+ Coverage 84.19% 84.23% +0.03%
==========================================
Files 235 235
Lines 7903 7903
Branches 693 693
==========================================
+ Hits 6654 6657 +3
+ Misses 1046 1042 -4
- Partials 203 204 +1
|
yggg
marked this pull request as ready for review
October 8, 2019 16:25
nnixaa
approved these changes
Oct 9, 2019
yggg
deleted the
fix/sidebar-emit-event-when-expanded-after-menu-click
branch
October 14, 2019 08:52
|
Hi, Is this bug fixed on version 5.0.0? I still do not get notifications from the service on:
Thanks, |
|
Also reporting on 5.0 - onToggle returns a notification, however onExpand doesn't return anything |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read and mark the following check list before creating a pull request:
Short description of what this resolves:
Closes #1432