Skip to content

fix(menu): clear typing for NbMenuItem pathMatch property - #1627

Merged
yggg merged 4 commits into
akveo:masterfrom
bram-pkg:patch-1
Jul 16, 2019
Merged

fix(menu): clear typing for NbMenuItem pathMatch property#1627
yggg merged 4 commits into
akveo:masterfrom
bram-pkg:patch-1

Conversation

@bram-pkg

Copy link
Copy Markdown
Contributor

Please read and mark the following check list before creating a pull request:

Short description of what this resolves:

It helps with autocompletion and helping the developer list all possible options.

@codecov

codecov Bot commented Jun 25, 2019

Copy link
Copy Markdown

Codecov Report

Merging #1627 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #1627   +/-   ##
=======================================
  Coverage   83.88%   83.88%           
=======================================
  Files         232      232           
  Lines        7595     7595           
  Branches      670      670           
=======================================
  Hits         6371     6371           
  Misses       1026     1026           
  Partials      198      198
Impacted Files Coverage Δ
...rc/framework/theme/components/menu/menu.service.ts 87.32% <100%> (ø) ⬆️

@yggg yggg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution @BramCeulemans

@yggg yggg changed the title Better typing for NbMenuItem#pathMatch fix(menu): clear typing for NbMenuItem pathMatch property Jul 16, 2019
@yggg
yggg merged commit 49bea48 into akveo:master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants