fix(menu): remove hardcoded max-height - #122
Merged
Merged
Conversation
KostyaDanovsky
previously requested changes
Jan 5, 2018
| } | ||
| }); | ||
| .pipe(takeWhile(() => this.alive)) | ||
| .pipe(filter(data => this.compareTag(data.tag))) |
Member
There was a problem hiding this comment.
It should be in the one pipe
| @@ -230,16 +278,17 @@ export class NbMenuComponent implements OnInit, OnDestroy { | |||
| } | |||
|
|
|||
| private getHomeItem(items: NbMenuItem[]): NbMenuItem { | |||
Member
There was a problem hiding this comment.
I believe you could rewrite this method more beautiful
| } | ||
| const oldValue = !!item.expanded; | ||
| item.expanded = false; | ||
| if (oldValue !== item.expanded) { |
Member
There was a problem hiding this comment.
Isn't it the same as if (oldValue)
nnixaa
approved these changes
Jan 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#65