refactor(managed-wallet): drop dead uakt bid-price ceiling, uact only

Deployments are uact-denominated, so the per-denom absolute ceiling only needs uact. Remove
the unused UAKT config key and the uakt branch; the relative check is denom-agnostic and
unaffected. A non-uact bid simply has no absolute cap and relies on the relative check.

Author: baktun14

apps/api/src/billing/config/env.config.ts

@@ -59,7 +59,6 @@ export const envSchema = z
       .transform(val => val === "true"),
     MANAGED_WALLET_BID_PRICE_WARN_MULTIPLIER: z.number({ coerce: true }).positive().default(5),
     MANAGED_WALLET_BID_PRICE_BLOCK_MULTIPLIER: z.number({ coerce: true }).positive().default(10),
-    MANAGED_WALLET_BID_PRICE_ABSOLUTE_MAX_UAKT: z.number({ coerce: true }).positive().optional(),
     MANAGED_WALLET_BID_PRICE_ABSOLUTE_MAX_UACT: z.number({ coerce: true }).positive().optional(),
     TX_SIGNER_BASE_URL: z.string()
   })

apps/api/src/billing/services/lease-bid-price-guard/lease-bid-price-guard.service.spec.ts

@@ -29,7 +29,7 @@ describe(LeaseBidPriceGuardService.name, () => {
         message: expect.stringContaining("cheapest competing bid")
       });
       expect(logger.error).toHaveBeenCalledWith(
-        expect.objectContaining({ event: "LEASE_BLOCKED_EXCESSIVE_BID_PRICE", reason: "relative", provider: "akash1prov", denom: "uakt" })
+        expect.objectContaining({ event: "LEASE_BLOCKED_EXCESSIVE_BID_PRICE", reason: "relative", provider: "akash1prov", denom: "uact" })
       );
     });
 
@@ -66,38 +66,38 @@ describe(LeaseBidPriceGuardService.name, () => {
 
   describe("absolute limit", () => {
     it("blocks a sole bidder priced above the per-denom ceiling", async () => {
-      const { service, logger } = setup({ absoluteMaxUakt: 1000, bids: [pricedBid(ACCEPTED, 2000)] });
+      const { service, logger } = setup({ absoluteMaxUact: 1000, bids: [pricedBid(ACCEPTED, 2000)] });
 
       await expect(service.validateLeaseBidPrices([leaseMessage(ACCEPTED)], createUserWallet())).rejects.toMatchObject({ status: 403 });
       expect(logger.error).toHaveBeenCalledWith(expect.objectContaining({ event: "LEASE_BLOCKED_EXCESSIVE_BID_PRICE", reason: "absolute" }));
     });
 
     it("allows a sole bidder priced below the per-denom ceiling", async () => {
-      const { service } = setup({ absoluteMaxUakt: 1000, bids: [pricedBid(ACCEPTED, 500)] });
+      const { service } = setup({ absoluteMaxUact: 1000, bids: [pricedBid(ACCEPTED, 500)] });
 
       await expect(service.validateLeaseBidPrices([leaseMessage(ACCEPTED)], createUserWallet())).resolves.toBeUndefined();
     });
 
-    it("allows a sole bidder at any price when no ceiling is configured for the denom", async () => {
-      const { service } = setup({ absoluteMaxUakt: undefined, bids: [pricedBid(ACCEPTED, 9_519_658)] });
+    it("allows a sole bidder at any price when no ceiling is configured", async () => {
+      const { service } = setup({ absoluteMaxUact: undefined, bids: [pricedBid(ACCEPTED, 9_519_658)] });
 
       await expect(service.validateLeaseBidPrices([leaseMessage(ACCEPTED)], createUserWallet())).resolves.toBeUndefined();
     });
 
     it("applies the ceiling independently of the relative check when peers exist", async () => {
       const { service, logger } = setup({
-        absoluteMaxUakt: 300,
+        absoluteMaxUact: 300,
         bids: [pricedBid(ACCEPTED, 400), pricedBid({ ...ACCEPTED, provider: "akash1cheap", bseq: 2 }, 100)]
       });
 
       await expect(service.validateLeaseBidPrices([leaseMessage(ACCEPTED)], createUserWallet())).rejects.toMatchObject({ status: 403 });
       expect(logger.error).toHaveBeenCalledWith(expect.objectContaining({ reason: "absolute" }));
     });
 
-    it("uses the uact ceiling for uact-denominated bids", async () => {
-      const { service } = setup({ absoluteMaxUact: 1000, bids: [pricedBid(ACCEPTED, 2000, "uact")] });
+    it("does not apply the ceiling to a non-uact denom", async () => {
+      const { service } = setup({ absoluteMaxUact: 1000, bids: [pricedBid(ACCEPTED, 2000, "uakt")] });
 
-      await expect(service.validateLeaseBidPrices([leaseMessage(ACCEPTED)], createUserWallet())).rejects.toMatchObject({ status: 403 });
+      await expect(service.validateLeaseBidPrices([leaseMessage(ACCEPTED)], createUserWallet())).resolves.toBeUndefined();
     });
   });
 
@@ -155,7 +155,7 @@ describe(LeaseBidPriceGuardService.name, () => {
     expect(logger.error).toHaveBeenCalledWith(expect.objectContaining({ reason: "relative", gseq: 2 }));
   });
 
-  function pricedBid(ids: { dseq: string; gseq: number; oseq: number; bseq: number; provider: string }, amount: number, denom = "uakt"): Bid {
+  function pricedBid(ids: { dseq: string; gseq: number; oseq: number; bseq: number; provider: string }, amount: number, denom = "uact"): Bid {
     const bid = createBid({ owner: OWNER, ...ids });
     bid.bid.price = { denom, amount: amount.toString() };
     return bid;
@@ -176,15 +176,13 @@ describe(LeaseBidPriceGuardService.name, () => {
     enabled?: boolean;
     warnMultiplier?: number;
     blockMultiplier?: number;
-    absoluteMaxUakt?: number;
     absoluteMaxUact?: number;
     bids?: Bid[];
   }) {
     const config = mockConfigService<BillingConfigService>({
       MANAGED_WALLET_BID_PRICE_GUARD_ENABLED: input.enabled ?? true,
       MANAGED_WALLET_BID_PRICE_WARN_MULTIPLIER: input.warnMultiplier ?? 5,
       MANAGED_WALLET_BID_PRICE_BLOCK_MULTIPLIER: input.blockMultiplier ?? 10,
-      MANAGED_WALLET_BID_PRICE_ABSOLUTE_MAX_UAKT: input.absoluteMaxUakt,
       MANAGED_WALLET_BID_PRICE_ABSOLUTE_MAX_UACT: input.absoluteMaxUact
     });
     const bidHttpService = mock<BidHttpService>();

apps/api/src/billing/services/lease-bid-price-guard/lease-bid-price-guard.service.ts

@@ -133,14 +133,9 @@ export class LeaseBidPriceGuardService {
     assert(false, 403, message);
   }
 
+  // Deployments are uact-denominated; the ceiling only applies to uact bids. Any other denom
+  // (e.g. a legacy uakt bid) has no absolute cap and is covered by the relative check alone.
   #getAbsoluteMax(denom: string): number | undefined {
-    switch (denom) {
-      case "uakt":
-        return this.config.get("MANAGED_WALLET_BID_PRICE_ABSOLUTE_MAX_UAKT");
-      case "uact":
-        return this.config.get("MANAGED_WALLET_BID_PRICE_ABSOLUTE_MAX_UACT");
-      default:
-        return undefined;
-    }
+    return denom === "uact" ? this.config.get("MANAGED_WALLET_BID_PRICE_ABSOLUTE_MAX_UACT") : undefined;
   }
 }