feat(framework)!: remove evals system end-to-end#261
Merged
Conversation
Remove the evals concept across the whole framework: trigger-test fixtures, the BM25 routing engine they fed, the skill-authoring path that produced them, and every gate and doc that referenced them. - delete 31 plugins/*/skills/*/evals/scenarios.json fixtures - delete aidd-context hooks/routing engine (bin, lib, routing-hint, tests) and unwire its SessionStart + UserPromptSubmit hooks; keep update_memory.js - drop the design-evals action and evals-template asset from 03-context-generate; renumber the skills action chain to 01-05 and the R-rules gate to R10 - remove the evals-validity check from lefthook.yml - scrub evals references from docs, memory, and per-plugin CATALOGs CHANGELOGs left untouched (release-please owns them). BREAKING CHANGE: auto-routing is removed. Skills are now manual-invoke only; the prompt-to-skill routing hint no longer runs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Baptiste LAFOURCADE <baptiste.lafourcade@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the evals concept across the whole framework end-to-end.
Why
The evals fixtures were not isolated test data: every
evals/scenarios.jsondoubled as the BM25 training corpus for the auto-routing hook. Removing evals therefore means removing the routing engine they fed, the authoring path that produced them, and the gates/docs that referenced them.Scope
plugins/*/skills/*/evals/scenarios.json.aidd-context/hooks/routing/(bin, lib, routing-hint, tests); unwire its SessionStart + UserPromptSubmit hooks inhooks.json(update_memory.jskept).02-design-evalsaction +evals-templateasset from03-context-generate; renumber the skills action chain to01-05and the tool-resolution gate toR10.evals-validityfromlefthook.yml; scrub evals references from docs, memory, and per-pluginCATALOG.md.Out of scope / preserved
CHANGELOG.mdfiles untouched (release-please owns them).evaluate/evaluationprose and theeval()injection warning in the security rule.Auto-routing is removed. Skills become manual-invoke only; the prompt-to-skill routing hint no longer runs.
Verification
scenarios.json/evals/left on disk; dangling-ref sweep clean.hooks.jsonvalid JSON;lefthook.ymlvalid YAML.05-reviewran: 2 renumber leftovers found (stale06-validateinclude,R11gate gap) and fixed.🤖 Generated with Claude Code