Skip to content

Commit 2e3ab24

Browse files
committed
feat: enhance documentation for challenge skill and add mermaid generation rules
1 parent f051c03 commit 2e3ab24

8 files changed

Lines changed: 506 additions & 174 deletions

File tree

aidd_docs/README.md

Lines changed: 395 additions & 104 deletions
Large diffs are not rendered by default.

aidd_docs/templates/docs/CATALOG.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,9 +139,8 @@ Auto-generated framework content: agents, commands, rules, skills, and templates
139139

140140
| File | Description | Argument Hint |
141141
| ------------------------------------------------------------ | ---------------------------------------------------------------------------------------- | ------------------------------------------------------------ |
142-
| [list_untested.md](../../commands/06_tests/list_untested.md) | `List all untested behaviors in codebase` | - |
143-
| [test_journey.md](../../commands/06_tests/test_journey.md) | `Test a user journey end-to-end by navigating and validating each step in the browser.` | `The user journey steps to validate and the URL to test on.` |
144-
| [write.md](../../commands/06_tests/write.md) | `Iterate on test creation and improvement until perfect test passes with best practices` | - |
142+
| [test.md](../../commands/06_tests/test.md) | `List untested behaviors and iterate on test creation until tests pass with best practices` | - |
143+
| [test_journey.md](../../commands/06_tests/test_journey.md) | `Test a user journey end-to-end by navigating and validating each step in the browser.` | `The user journey steps to validate and the URL to test on.` |
145144

146145
#### `commands/07_documentation`
147146

commands/06_tests/list_untested.md

Lines changed: 0 additions & 26 deletions
This file was deleted.

commands/06_tests/test.md

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,46 @@
1+
---
2+
name: test
3+
description: List untested behaviors and iterate on test creation until tests pass with best practices
4+
model: sonnet
5+
---
6+
7+
# Test Iterator Prompt
8+
9+
## Goal
10+
11+
Identify untested behaviors in the feature, then create and iterate on tests until they pass with modern testing best practices.
12+
13+
## Context
14+
15+
- Current project testing framework and conventions
16+
- Test coverage and quality metrics
17+
18+
### Testing rules
19+
20+
```markdown
21+
@{{TOOLS}}/rules/
22+
```
23+
24+
## Rules
25+
26+
- Focus on ONE test at a time
27+
- Apply current testing best practices
28+
- Continue iterating until test passes AND meets quality criteria
29+
- Never compromise on test quality for speed
30+
- Focus on functional aspects only, ignore technical details
31+
32+
## Process steps
33+
34+
1. List untested behaviors in the target area
35+
1. Think about behaviors to test based on existing ones
36+
2. Determine a score, 0: not needed, 5: critical core flow to test
37+
3. Group them by distinct sections
38+
4. Prioritize based on score and impact
39+
5. Display organized minimal bullet list of untested behaviors
40+
2. Pick the highest-priority untested behavior
41+
3. Generate initial test with best practices
42+
4. Run test and capture results
43+
1. If test fails: analyze failure, improve test, repeat from step 4
44+
2. If test passes: validate against quality checklist
45+
3. If quality insufficient: improve test quality, repeat from step 4
46+
5. Move to next untested behavior, repeat from step 2

commands/06_tests/write.md

Lines changed: 0 additions & 38 deletions
This file was deleted.

rules/01-standards/1-mermaid.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ alwaysApply: false
1010

1111
- Always have title in schema using "---" to define it
1212

13+
## Global
14+
15+
- NEVER use "\n"
16+
1317
## States and nodes
1418

1519
- Define groups, parents, children
@@ -25,7 +29,6 @@ alwaysApply: false
2529
- Consistent naming throughout
2630
- Descriptive names (no "A", "B")
2731
- Surround names with quotes
28-
- NEVER use "\n"
2932
- Replace ":" with "$" in state names
3033

3134
## Links

skills/challenge/SKILL.md

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
---
2+
name: challenge
3+
description: >-
4+
Review and challenge previous work for improvements and correctness.
5+
Use when the user says 'challenge this', 'review my work', 'is this correct',
6+
asks for a critical review, or wants to rethink a decision.
7+
---
8+
9+
# Challenge
10+
11+
## Goal
12+
13+
Critically review previous work to ensure 100% correctness, identify edge cases, and suggest improvements.
14+
15+
## Rules
16+
17+
- When no "Deal breakers", then correctness is 100%.
18+
- Challenge assumptions and decisions.
19+
- Look for edge cases, errors, inconsistencies, missing parts, duplications.
20+
- Aim for simplifications — every step must be logical without gaps.
21+
- Think in first principles.
22+
23+
## Process
24+
25+
1. Review previous work in detail using: {{TOOLS}}/commands/02_context/challenge.md
26+
2. Identify potential issues or areas for improvement.
27+
3. Suggest changes or enhancements.
28+
29+
## Output Format
30+
31+
```text
32+
My confidence level of correctness now: XX%
33+
34+
# Previous work to review
35+
36+
## ✅ 100% correctness
37+
38+
-
39+
-
40+
41+
## ❌ Deal breakers
42+
43+
-
44+
-
45+
-
46+
47+
## 🙏 Suggestions (enhancements only)
48+
49+
-
50+
-
51+
```

templates/docs/CATALOG.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ Auto-generated framework content: agents, commands, rules, skills, and templates
2929
- [`scripts`](#scripts)
3030
- [`skills`](#skills)
3131
- [`skills/aidd-auto-implement`](#skillsaidd-auto-implement)
32+
- [`skills/challenge`](#skillschallenge)
3233
- [`templates`](#templates)
3334
- [`templates/docs`](#templatesdocs)
3435

@@ -155,9 +156,8 @@ No files found.
155156

156157
| File | Description | Argument Hint |
157158
|------|---|---|
158-
| [list_untested.md](../../commands/06_tests/list_untested.md) | `List all untested behaviors in codebase` | - |
159159
| [test_journey.md](../../commands/06_tests/test_journey.md) | `Test a user journey end-to-end by navigating and validating each step in the browser.` | `The user journey steps to validate and the URL to test on.` |
160-
| [write.md](../../commands/06_tests/write.md) | `Iterate on test creation and improvement until perfect test passes with best practices` | - |
160+
| [test.md](../../commands/06_tests/test.md) | `List untested behaviors and iterate on test creation until tests pass with best practices` | - |
161161

162162
#### `commands/07_documentation`
163163

@@ -224,6 +224,12 @@ No files found.
224224
|------|---|---|
225225
| [SKILL.md](../../skills/aidd-auto-implement/SKILL.md) | `Autonomously run the AI-Driven Development workflow to code an high quality feature.` | `The URL or file path of the issue or task to implement.` |
226226

227+
#### `skills/challenge`
228+
229+
| File | Description |
230+
|------|---|
231+
| [SKILL.md](../../skills/challenge/SKILL.md) | `Review and challenge previous work for improvements and correctness. Use when the user says 'challenge this', 'review my work', 'is this correct', asks for a critical review, or wants to rethink a decision.` |
232+
227233
### `templates`
228234

229235
#### `templates/docs`

0 commit comments

Comments
 (0)