Skip to content

Commit bb24988

Browse files
bokelleyclaude
andauthored
feat(agents): triage PR ergonomics — refs adcp#3121 (#95)
Mirrors adcontextprotocol/adcp#3172. Three coordinated edits to .agents/routines/triage-prompt.md: 1. Pre-PR gate: do not declare "approved" while build is red. 2. PR body now carries a "Triage-managed PR" block documenting the no-iteration policy (push fixup commits or re-trigger via /triage on the source issue). 3. claude-triaged label applied to PR after gh pr create (mirrors issue label, searchable from PR list views). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 06004da commit bb24988

1 file changed

Lines changed: 37 additions & 3 deletions

File tree

.agents/routines/triage-prompt.md

Lines changed: 37 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,9 @@ unit tests pass.
364364
2. **If build or tests fail:** read the errors, fix the code,
365365
re-run. Cap at **2 build→fix iterations.** If still failing,
366366
abandon the PR and Flag for human review with the build log
367-
in the comment.
367+
in the comment. **Do not declare "approved" in the pre-PR
368+
review block while build is red** — that's a trust-eroding
369+
signal (per adcp#3121).
368370
3. Do **not** skip tests locally because "CI will run them." The
369371
point of this gate is to not ship known-broken code even as a
370372
draft, because (a) review noise, (b) a human reviewer may
@@ -416,8 +418,40 @@ have read the diff before a human reviewer does.
416418
- Branch: `claude/issue-<N>-<short-slug>`
417419
- Status: **draft**
418420
- Title: conventional-commits (`fix(router): …`, `fix: …`)
419-
- Body: `Closes #N`, summary, what-tested, **Pre-PR review** block with
420-
security-reviewer explicitly called out, `Session:` link
421+
- Body, in order:
422+
- `Closes #N`
423+
- One-paragraph summary
424+
- What-tested list (go build / vet / test / golangci-lint results)
425+
- **Pre-PR review** block with both experts' one-line sign-off
426+
(security-reviewer always called out for this repo's posture)
427+
- **Triage-managed PR block** — append this verbatim before the
428+
`Session:` link so reviewers know the iteration policy:
429+
430+
```
431+
> **Triage-managed PR.** This bot does not currently iterate on
432+
> review comments or PR conversation threads (only on the source
433+
> issue). To unblock:
434+
>
435+
> - **Push fixup commits directly:** `gh pr checkout <num>` →
436+
> fix → push.
437+
> - **Or re-trigger:** comment `/triage execute` on the source
438+
> issue.
439+
>
440+
> See [adcp#3121](https://github.com/adcontextprotocol/adcp/issues/3121)
441+
> for context.
442+
```
443+
- `Session: https://claude.ai/code/${CLAUDE_CODE_REMOTE_SESSION_ID}`
444+
- **After `gh pr create` succeeds**, label the PR `claude-triaged`
445+
so it's searchable from PR list views (mirrors the issue label):
446+
447+
```
448+
gh pr edit <PR#> --repo <owner>/<repo> --add-label claude-triaged
449+
```
450+
451+
(Don't apply `claude-triaging` to the PR — that label is the
452+
routine's "I'm working on this **issue**" signal, not a PR
453+
ownership marker.)
454+
421455
- Before pushing:
422456
- `go build ./...`
423457
- `go vet ./...`

0 commit comments

Comments
 (0)