Skip to content

Commit ad17812

Browse files
bokelleyclaude
andcommitted
ci(adcp): use 127.0.0.1 instead of localhost for storyboard probes
Acting on dx-expert review of this PR: On dual-stack hosts (and Ubuntu runners since actions/runner 2.300+), ``localhost`` resolves to ``::1`` first. uvicorn's default bind is IPv4-only, so the readiness probe and runner invocation each eat a connection-refused round-trip on ``::1`` before falling back to ``127.0.0.1``. Curl falls back automatically (so it still works), but it's wasteful and slightly fragile. Pin both call sites to ``127.0.0.1`` directly. The agent's bind address is unchanged (still ``0.0.0.0`` via ``ADCP_HOST`` default in #296); only the client-side address resolution changes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent bfe5ca8 commit ad17812

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@ jobs:
364364
# Any HTTP response (including 405 on GET to a POST-only endpoint)
365365
# means the server is up and accepting connections.
366366
HTTP_CODE=$(curl -s -o /dev/null -w "%{http_code}" --max-time 1 \
367-
http://localhost:3001/mcp 2>/dev/null || echo "000")
367+
http://127.0.0.1:3001/mcp 2>/dev/null || echo "000")
368368
if [ "$HTTP_CODE" != "000" ]; then
369369
echo "Seller agent ready (HTTP ${HTTP_CODE}, pid ${AGENT_PID})"
370370
break
@@ -388,7 +388,7 @@ jobs:
388388
# drift as soon as it ships, which is the point of this job.
389389
run: |
390390
npx -y -p @adcp/client@latest adcp storyboard run \
391-
http://localhost:3001/mcp media_buy_seller \
391+
http://127.0.0.1:3001/mcp media_buy_seller \
392392
--json --allow-http \
393393
> storyboard-result.json
394394

0 commit comments

Comments
 (0)