fix(webhook): patch Protocol gap, add Pg discoverability, fix vacuous test

- WebhookDeliverySupervisor Protocol was missing breaker_key and
  notification_type kwargs that exist on InMemoryWebhookDeliverySupervisor;
  typed call-sites against the Protocol were broken
- Re-export PgWebhookDeliverySupervisor from adcp.webhooks so it is
  discoverable without knowing the internal module path
- test_log_insert_failure_does_not_crash_worker was passing vacuously
  because fetchone on the log cursor was set to raise but _log_attempt_via_conn
  never calls fetchone; fix by raising directly from conn.execute side-effect
- Remove dead _send inner function from test_warning_emitted_only_once

https://claude.ai/code/session_01DoCRKpgu6jrVNARmazguok

Author: claude

src/adcp/webhook_supervisor.py

@@ -214,6 +214,8 @@ async def send_mcp(
         result: Any = None,
         token: str | None = None,
         sequence_key: str | None = None,
+        breaker_key: str | None = None,
+        notification_type: str | None = None,
     ) -> WebhookDeliveryResult | None: ...
 
 

src/adcp/webhooks.py

@@ -1157,6 +1157,9 @@ def _validate_header_value(name: str, value: Any) -> None:
     WebhookDeliveryResult,
     WebhookSender,
 )
+from adcp.webhook_supervisor_pg import (  # noqa: E402
+    PgWebhookDeliverySupervisor,
+)
 
 __all__ = [
     # Sender — payload builders
@@ -1193,4 +1196,6 @@ def _validate_header_value(name: str, value: Any) -> None:
     # Dedup / idempotency backends (re-exported so one import root suffices)
     "MemoryBackend",
     "WebhookDedupStore",
+    # Pg-backed supervisor (requires adcp[pg] extra)
+    "PgWebhookDeliverySupervisor",
 ]

tests/test_webhook_supervisor_pg.py

@@ -279,15 +279,6 @@ async def test_warning_emitted_before_worker_starts(self, caplog: Any) -> None:
     async def test_warning_emitted_only_once(self, caplog: Any) -> None:
         import logging
 
-        async def _send(pool: Any) -> None:
-            conn_c = _make_conn(None)
-            conn_e = _make_conn((1,))
-            _pool = _make_pool(conn_c, conn_e)
-            sup = _make_supervisor(_pool, _make_sender())
-            with caplog.at_level(logging.WARNING, logger="adcp.webhook_supervisor_pg"):
-                await sup.send_mcp(url="u", task_id="t", status="s")
-                await sup.send_mcp(url="u", task_id="t", status="s")
-
         # Two calls on same supervisor → one warning
         conn_c1 = _make_conn(None)
         conn_e1 = _make_conn((1,))
@@ -608,11 +599,9 @@ async def test_log_insert_failure_does_not_crash_worker(self) -> None:
         poll_cur = _cursor(_queue_row())
         delete_cur = _cursor(None)
         circuit_cur = _cursor(("closed", 0))
-        log_error_cur = AsyncMock()
-        log_error_cur.fetchone = AsyncMock(side_effect=RuntimeError("DB gone"))
 
         conn.execute = AsyncMock(
-            side_effect=[poll_cur, delete_cur, circuit_cur, log_error_cur]
+            side_effect=[poll_cur, delete_cur, circuit_cur, RuntimeError("DB gone")]
         )
         ctx = AsyncMock()
         ctx.__aenter__ = AsyncMock(return_value=conn)