Skip to content

Commit 0af6098

Browse files
bokelleyclaude
andauthored
ci: promote v3 reference seller storyboard to required (@adcp/sdk@6.7) (#451)
* ci: promote v3 reference seller storyboard to required (@adcp/sdk@6.7) @adcp/sdk@6.7.0 publishes the sales-guaranteed mock-server (closes #449). The v3 reference seller's translator pattern can now run end-to-end in CI: JS mock-server upstream + Postgres + Python seller + storyboard runner + /_debug/traffic counter assertions. Drop ``continue-on-error: true`` so spec-conformance regressions on the translator pattern (response shape drift, mock-mapping bugs, traffic-counter mismatches) gate every PR going forward. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(ci): install example-local deps in storyboard-v3 job (sqlalchemy+asyncpg+respx) --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent 386cb15 commit 0af6098

1 file changed

Lines changed: 8 additions & 4 deletions

File tree

.github/workflows/ci.yml

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -482,10 +482,9 @@ jobs:
482482
storyboard-v3-reference-seller:
483483
name: AdCP storyboard runner — v3 reference seller (translator)
484484
runs-on: ubuntu-latest
485-
# Non-blocking until storyboard tooling settles for the translator
486-
# pattern. Promote to required once the JS mock-server's
487-
# sales-guaranteed surface is canonical.
488-
continue-on-error: true
485+
# Required as of @adcp/sdk@6.7.0 (sales-guaranteed mock-server
486+
# canonicalized; closes #449). Storyboard run + traffic-counter
487+
# assertions gate every PR's translator-pattern conformance.
489488
services:
490489
postgres:
491490
image: postgres:16
@@ -529,6 +528,11 @@ jobs:
529528
run: |
530529
python -m pip install --upgrade pip
531530
pip install -e ".[dev,pg]"
531+
# Example-local deps: the v3 reference seller imports
532+
# sqlalchemy + asyncpg (async Postgres driver) which aren't
533+
# in the SDK's [dev,pg] extras. Install inline rather than
534+
# adding an example-only optional-dependencies group.
535+
pip install "sqlalchemy>=2.0" "asyncpg>=0.29" "respx>=0.20"
532536
533537
- name: Pre-install @adcp/sdk (once, then call binary directly)
534538
run: |

0 commit comments

Comments
 (0)