Add exponential backoff when retrying

Author: konradpabjan

packages/artifact/__tests__/retry.test.ts

@@ -1,6 +1,8 @@
 import {retry} from '../src/internal/requestUtils'
 import * as core from '@actions/core'
 
+jest.mock('../src/internal/config-variables')
+
 interface ITestResponse {
   statusCode: number
   result: string | null
@@ -52,8 +54,7 @@ async function testRetryExpectingResult(
     async () => handleResponse(responses.pop()),
     (response: ITestResponse) => response.statusCode,
     new Map(), // extra error message for any particular http codes
-    2, // maxAttempts
-    0 // delay
+    2 // maxAttempts
   )
 
   expect(actualResult.result).toEqual(expectedResult)
@@ -70,8 +71,7 @@ async function testRetryExpectingError(
       async () => handleResponse(responses.pop()),
       (response: ITestResponse) => response.statusCode,
       new Map(), // extra error message for any particular http codes
-      2, // maxAttempts,
-      0 // delay
+      2 // maxAttempts,
     )
   ).rejects.toBeInstanceOf(Error)
 }

packages/artifact/src/internal/requestUtils.ts

@@ -1,14 +1,19 @@
 import {IHttpClientResponse} from '@actions/http-client/interfaces'
-import {isRetryableStatusCode, isSuccessStatusCode, sleep} from './utils'
+import {
+  isRetryableStatusCode,
+  isSuccessStatusCode,
+  sleep,
+  getExponentialRetryTimeInMilliseconds
+} from './utils'
 import * as core from '@actions/core'
+import {getRetryLimit} from './config-variables'
 
 export async function retry<T>(
   name: string,
   operation: () => Promise<T>,
   getStatusCode: (response: T) => number | undefined,
   errorMessages: Map<number, string>,
-  maxAttempts: number,
-  delayMilliseconds: number
+  maxAttempts: number
 ): Promise<T> {
   let response: T | undefined = undefined
   let statusCode: number | undefined = undefined
@@ -47,7 +52,7 @@ export async function retry<T>(
       `${name} - Attempt ${attempt} of ${maxAttempts} failed with error: ${errorMessage}`
     )
 
-    await sleep(delayMilliseconds)
+    await sleep(getExponentialRetryTimeInMilliseconds(attempt))
     attempt++
   }
 
@@ -61,14 +66,13 @@ export async function retryHttpClientRequest<T>(
   name: string,
   method: () => Promise<IHttpClientResponse>,
   errorMessages: Map<number, string> = new Map(),
-  maxAttempts = 3
+  maxAttempts = getRetryLimit()
 ): Promise<IHttpClientResponse> {
   return await retry(
     name,
     method,
     (response: IHttpClientResponse) => response.message.statusCode,
     errorMessages,
-    maxAttempts,
-    5000
+    maxAttempts
   )
 }