fix: address CodeRabbit comments on PR #770

- websocket.ts: wrap message handler in try/catch with shape validation
- daemon-bootstrap.ts: register missing task.start/session.resume/permission.respond RPCs
- pnpm-lock.yaml: regenerate after adding daemon package
Addresses: 2971335381, 2971335383, 2971335385

Author: Avishay Mashiach

apps/daemon/src/websocket.ts

@@ -29,8 +29,29 @@ export function setupWebSocket(server: Server): WebSocketServer {
     console.log('[WebSocket] Client connected. Total:', wss!.clients.size);
 
     ws.on('message', (raw) => {
-      const msg = JSON.parse(raw.toString()) as ClientMessage;
-      messageHandlers.forEach((handler) => handler(msg));
+      let msg: ClientMessage;
+      try {
+        const parsed = JSON.parse(raw.toString()) as unknown;
+        if (
+          typeof parsed !== 'object' ||
+          parsed === null ||
+          typeof (parsed as Record<string, unknown>).type !== 'string'
+        ) {
+          console.warn('[WebSocket] Received message with invalid shape, ignoring');
+          return;
+        }
+        msg = parsed as ClientMessage;
+      } catch (err) {
+        console.warn('[WebSocket] Failed to parse incoming message:', err);
+        return;
+      }
+      messageHandlers.forEach((handler) => {
+        try {
+          handler(msg);
+        } catch (err) {
+          console.error('[WebSocket] Handler error:', err);
+        }
+      });
     });
 
     ws.on('close', () => {
@@ -65,4 +86,4 @@ export function onClientMessage(handler: MessageHandler): () => void {
 
 export function getConnectedClientCount(): number {
   return wss?.clients.size ?? 0;
-}
+}

apps/desktop/src/main/daemon-bootstrap.ts

@@ -20,8 +20,18 @@ import {
   listScheduledTasks,
   cancelScheduledTask,
   disposeScheduler,
+  mapResultToStatus,
+  createTaskId,
+} from '@accomplish_ai/agent-core';
+import type {
+  TaskManagerAPI,
+  StorageAPI,
+  TaskCallbacks,
+  TaskMessage,
+  TaskResult,
+  TaskStatus,
+  PermissionResponse,
 } from '@accomplish_ai/agent-core';
-import type { TaskManagerAPI, StorageAPI } from '@accomplish_ai/agent-core';
 import { app } from 'electron';
 
 let server: DaemonServer | null = null;
@@ -161,6 +171,48 @@ function getDaemonEntryPath(): string {
   return path.join(app.getAppPath(), 'out', 'main', 'daemon', 'entry.js');
 }
 
+/**
+ * Build task lifecycle callbacks that forward events back through the in-process DaemonServer.
+ */
+function buildInProcessCallbacks(
+  taskId: string,
+  srv: DaemonServer,
+  storage: StorageAPI,
+): TaskCallbacks {
+  return {
+    onBatchedMessages: (messages: TaskMessage[]) => {
+      for (const msg of messages) {
+        storage.addTaskMessage(taskId, msg);
+      }
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      srv.notify('task.message' as any, { taskId, messages });
+    },
+    onProgress: (progress) => {
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      srv.notify('task.progress' as any, { taskId, ...progress });
+    },
+    onPermissionRequest: (request) => {
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      srv.notify('permission.request' as any, request);
+    },
+    onComplete: (result: TaskResult) => {
+      const taskStatus = mapResultToStatus(result);
+      storage.updateTaskStatus(taskId, taskStatus, new Date().toISOString());
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      srv.notify('task.complete' as any, { taskId, result });
+    },
+    onError: (error: Error) => {
+      storage.updateTaskStatus(taskId, 'failed', new Date().toISOString());
+      console.error(`[DaemonBootstrap] Task ${taskId} error:`, error.message);
+    },
+    onStatusChange: (status: TaskStatus) => {
+      storage.updateTaskStatus(taskId, status, new Date().toISOString());
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      srv.notify('task.statusChange' as any, { taskId, status });
+    },
+  };
+}
+
 /**
  * Register in-process daemon handlers (same as daemon/entry.ts).
  */
@@ -273,6 +325,57 @@ function registerInProcessHandlers(
     }
   });
 
+  // ── Task execution ────────────────────────────────────────────────
+
+  srv.registerMethod('task.start', async (params) => {
+    const { taskId: providedTaskId, config } = params;
+    const taskId = providedTaskId ?? createTaskId();
+
+    const callbacks = buildInProcessCallbacks(taskId, srv, storage);
+    const task = await taskManager.startTask(taskId, config, callbacks);
+    storage.saveTask(task);
+    return task;
+  });
+
+  srv.registerMethod('session.resume', async (params) => {
+    const { sessionId, prompt, existingTaskId } = params;
+    const taskId = existingTaskId ?? createTaskId();
+
+    const callbacks = buildInProcessCallbacks(taskId, srv, storage);
+    const task = await taskManager.startTask(taskId, { prompt, sessionId }, callbacks);
+
+    if (existingTaskId) {
+      storage.updateTaskStatus(existingTaskId, task.status, new Date().toISOString());
+    } else {
+      storage.saveTask(task);
+    }
+
+    return task;
+  });
+
+  srv.registerMethod('permission.respond', async (params) => {
+    const { response } = params;
+    const { taskId, decision, requestId, selectedOptions } = response as PermissionResponse;
+
+    if (!taskManager.hasActiveTask(taskId)) {
+      console.warn(`[DaemonBootstrap] Permission response for inactive task ${taskId}`);
+      return;
+    }
+
+    if (requestId) {
+      // requestId-based responses are handled externally (permission-api); log and skip
+      console.warn(`[DaemonBootstrap] Unhandled requestId-based permission.respond: ${requestId}`);
+      return;
+    }
+
+    if (decision === 'allow') {
+      const message = selectedOptions?.join(', ') || 'yes';
+      await taskManager.sendResponse(taskId, message);
+    } else {
+      await taskManager.sendResponse(taskId, 'no');
+    }
+  });
+
   // ── Scheduling ───────────────────────────────────────────────────
 
   srv.registerMethod('task.schedule', (params) => {
@@ -338,4 +441,4 @@ export function shutdownDaemon(): void {
   disposeScheduler();
   mode = null;
   console.log('[DaemonBootstrap] Daemon shut down');
-}
+}