fix(maven): Preserve XML attributes when updating pom.xml files#279
Merged
TimothyJones merged 3 commits intomasterfrom Mar 18, 2026
Merged
fix(maven): Preserve XML attributes when updating pom.xml files#279TimothyJones merged 3 commits intomasterfrom
TimothyJones merged 3 commits intomasterfrom
Conversation
The XMLParser and XMLBuilder from fast-xml-parser were instantiated without attribute-related options, causing all XML attributes to be silently stripped during version bumping. This corrupted pom.xml files that contained elements with attributes (e.g., plugin configurations). Configure the parser with ignoreAttributes: false, parseTagValue: false, and parseAttributeValue: false, and the builder with matching options to preserve attributes, prevent boolean shorthand, and handle self-closing tags correctly. Fixes #268 https://claude.ai/code/session_01MnZuTu64zEfCCP1edZDdo8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #268, XML attributes were silently stripped.
This is because the XMLParser and XMLBuilder from fast-xml-parser were instantiated
without attribute-related options, and for some reason it defaults to ignoring them. I'm going to assume there's a good reason for that, because... maybe there is one? Who can say.
Anyway, this PR fixes the issue by configuring the parser not to ignore attributes, and configuring the builder to emit them.
Thanks Claude for making diagnosing this issue super easy.