Skip to content

fix: version returned from prebump lifecycle script was not used in some cases#186

Merged
TimothyJones merged 1 commit intoabsolute-version:masterfrom
singh-inder:master
Sep 15, 2024
Merged

fix: version returned from prebump lifecycle script was not used in some cases#186
TimothyJones merged 1 commit intoabsolute-version:masterfrom
singh-inder:master

Conversation

@singh-inder
Copy link
Copy Markdown
Contributor

@singh-inder singh-inder commented Sep 13, 2024

Fixes #185

@singh-inder singh-inder changed the title Fixes #185: version returned from prebump lifecycle script not being used Fixes version returned from prebump lifecycle script not being used Sep 13, 2024
@singh-inder singh-inder changed the title Fixes version returned from prebump lifecycle script not being used Fix version returned from prebump lifecycle script not being used Sep 13, 2024
@singh-inder singh-inder reopened this Sep 13, 2024
@TimothyJones
Copy link
Copy Markdown
Member

Thanks so much for this! I’ll take a look tomorrow and get this released

@TimothyJones TimothyJones changed the title Fix version returned from prebump lifecycle script not being used fix: version returned from prebump lifecycle script was not used in some cases Sep 15, 2024
@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.88%. Comparing base (7ebdacd) to head (11f616f).
Report is 23 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #186      +/-   ##
==========================================
- Coverage   94.11%   92.88%   -1.24%     
==========================================
  Files          26       28       +2     
  Lines         493      520      +27     
==========================================
+ Hits          464      483      +19     
- Misses         29       37       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimothyJones TimothyJones merged commit 8dbeb79 into absolute-version:master Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

version returned from prebump lifecycle script not being used

3 participants