make eslint manual fixes

Author: lukasvice

src/async-data/AsyncView.tsx

@@ -1,4 +1,4 @@
-import { ReactElement, ReactNode } from 'react'
+import { ReactNode } from 'react'
 import { isFunction } from '../util'
 
 type LoadingFunction = () => ReactNode
@@ -36,8 +36,7 @@ type Props<Data, Error> = {
 
 const AsyncView = <Data, Error>(
   props: Props<Data, Error>,
-  // The `ReactElement<any, any> | null` type is for React 17 compatibility (see type FunctionComponent). With React 18 it can be a ReactNode and we can remove the Fragment wrappers.
-): ReactElement<any, any> | null => {
+): ReactNode | null => {
   const {
     data,
     error,

src/async-data/asyncState.js

@@ -16,9 +16,9 @@ var AsyncState
  * inference.
  */
 const getAsyncState = (data, error) => {
-  if (error != null && error != undefined) {
+  if (error !== null && error !== undefined) {
     return AsyncState.FINISHED_WITH_ERROR
-  } else if (data != null && data != undefined) {
+  } else if (data !== null && data !== undefined) {
     return AsyncState.FINISHED_WITH_SUCCESS
   } else {
     return AsyncState.FETCHING

src/async-data/asyncState.ts

@@ -15,9 +15,9 @@ enum AsyncState {
  * inference.
  */
 const getAsyncState = (data: unknown, error: unknown): AsyncState => {
-  if (error != null && error != undefined) {
+  if (error !== null && error !== undefined) {
     return AsyncState.FINISHED_WITH_ERROR
-  } else if (data != null && data != undefined) {
+  } else if (data !== null && data !== undefined) {
     return AsyncState.FINISHED_WITH_SUCCESS
   } else {
     return AsyncState.FETCHING

src/location-provider/getCurrentLocation.js

@@ -4,14 +4,14 @@ const getCurrentLocation = (highAccuracy = false) => {
       resolve(position)
     }
     const errorCallback = (error) => {
-      reject(error.message)
+      reject(new Error(error.message))
     }
     if (navigator.geolocation) {
       navigator.geolocation.getCurrentPosition(successCallback, errorCallback, {
         enableHighAccuracy: highAccuracy,
       })
     } else {
-      reject('Geolocation not supported')
+      reject(new Error('Geolocation not supported'))
     }
   })
 }

src/location-provider/getCurrentLocation.ts

@@ -7,15 +7,16 @@ const getCurrentLocation = (
     }
 
     const errorCallback = (error: GeolocationPositionError) => {
-      reject(error.message)
+      reject(new Error(error.message))
     }
 
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
     if (navigator.geolocation) {
       navigator.geolocation.getCurrentPosition(successCallback, errorCallback, {
         enableHighAccuracy: highAccuracy,
       })
     } else {
-      reject('Geolocation not supported')
+      reject(new Error('Geolocation not supported'))
     }
   })
 }

src/useInterval/useInterval.ts

@@ -1,6 +1,6 @@
 import { useEffect, useRef } from 'react'
 
-type Callback = () => unknown | void
+type Callback = () => unknown
 type Delay = number | null
 
 const useInterval = (callback: Callback, delay: Delay): void => {

src/useMatchMediaQuery/__test__/useMatchMediaQuery.test.tsx

@@ -1,11 +1,10 @@
 import { RenderResult, render } from '@testing-library/react'
 import isMatching from 'css-mediaquery'
-import React from 'react'
 import { useMatchMediaQuery } from '../useMatchMediaQuery'
 
 beforeEach(() => {
   // mock window.matchMedia (use 'css-mediaquery')
-  window.matchMedia = jest.fn().mockImplementation((query) => {
+  window.matchMedia = jest.fn().mockImplementation((query: string) => {
     return {
       addListener: jest.fn(),
       media: query,

src/useMatchMediaQuery/useMatchMediaQuery.ts

@@ -1,6 +1,7 @@
 import { useEffect, useState } from 'react'
 
 function useMatchMediaQuery(query: string): boolean | undefined {
+  // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
   if (typeof window !== 'object' || !window.matchMedia) {
     return
   }
@@ -18,12 +19,14 @@ function useMatchMediaQuery(query: string): boolean | undefined {
       setMatches(media.matches)
     }
 
+    // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
     if (media.addEventListener) {
       media.addEventListener('change', listener)
     }
 
     return () => {
-      media.removeEventListener && media.removeEventListener('change', listener)
+      // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
+      media.removeEventListener?.('change', listener)
     }
   }, [matches, query])
 

src/util.js

@@ -1,2 +1 @@
-// eslint-disable-next-line @typescript-eslint/ban-types
 export const isFunction = (obj) => typeof obj === 'function'

src/util.ts

@@ -1,3 +1,3 @@
-// eslint-disable-next-line @typescript-eslint/ban-types
+// eslint-disable-next-line @typescript-eslint/no-unsafe-function-type
 export const isFunction = (obj: unknown): obj is Function =>
   typeof obj === 'function'