Skip to content

Commit 5f1817a

Browse files
authored
Merge pull request #124 from abcnews/feat/decoyRendered
feat: emit decoyRendered when odyssey finishes rendering
2 parents 7c495d8 + 91d4233 commit 5f1817a

5 files changed

Lines changed: 14 additions & 23 deletions

File tree

-39.9 KB
Loading
-29.4 KB
Loading

package-lock.json

Lines changed: 5 additions & 20 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"dependencies": {
2323
"@abcnews/alternating-case-to-object": "^3.2.0",
2424
"@abcnews/dev-proxy": "^1.3.0",
25-
"@abcnews/env-utils": "^6.0.0",
25+
"@abcnews/env-utils": "^6.1.0",
2626
"@abcnews/url2cmid": "^1.1.0",
2727
"classnames": "^2.2.6",
2828
"core-js": "^3.23.4",

src/index.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,20 @@ proxy('odyssey').then(() => {
3737
// Try again, once.
3838
// It appears possible that sometimes this request is made before PL sets up the decoy request listener
3939
// See: NEWSWEB-3258
40-
debug('Attempting second request for "body" DOM permit');
4140
return requestDOMPermit('body');
4241
});
4342
debug('Requested "body" DOM permit');
4443
debugWhen(obtainBodyDOMPermitTask, 'Obtained "body" DOM permit');
4544

4645
// ...we can run the app, using the terminus document to initialise metadata
4746
Promise.all([importAppModuleTask, fetchArticleDocumentTask, obtainBodyDOMPermitTask]).then(
48-
([appModule, terminusDocument]) => appModule.default(terminusDocument)
47+
([appModule, terminusDocument, domPermit]) => {
48+
appModule.default(terminusDocument);
49+
50+
// Let PL know we're ready to load "islands" back in, such as expandable cards.
51+
if (domPermit && typeof domPermit.onRender === 'function') {
52+
domPermit.onRender();
53+
}
54+
}
4955
);
5056
});

0 commit comments

Comments
 (0)