Skip to content

Commit 57b2f9a

Browse files
authored
Merge pull request #83 from Yoast/JRF/ghactions-various-tweaks
GH Actions: various tweaks
2 parents b0c727e + 00bf401 commit 57b2f9a

3 files changed

Lines changed: 10 additions & 16 deletions

File tree

.github/workflows/cs.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,9 @@ jobs:
4141

4242
# Check the code-style consistency of the PHP files.
4343
- name: Check PHP code style
44-
continue-on-error: true
44+
id: phpcs
4545
run: composer check-cs -- --report-full --report-checkstyle=./phpcs-report.xml
4646

4747
- name: Show PHPCS results in PR
48+
if: ${{ always() && steps.phpcs.outcome == 'failure' }}
4849
run: cs2pr ./phpcs-report.xml

.github/workflows/lint.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,6 @@ jobs:
2424

2525
name: "Lint: PHP ${{ matrix.php }}"
2626

27-
continue-on-error: ${{ matrix.php == '8.2' }}
28-
2927
steps:
3028
- name: Checkout code
3129
uses: actions/checkout@v3

.github/workflows/test.yml

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020

2121
strategy:
2222
matrix:
23-
php: ['5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1']
23+
php: ['5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2']
2424
phpunit: ['auto']
2525
experimental: [false]
2626

@@ -55,13 +55,16 @@ jobs:
5555
- php: '8.0'
5656
phpunit: '9.3.0'
5757
experimental: false
58+
- php: '8.1'
59+
phpunit: '9.3.0'
60+
experimental: false
5861

5962
# Experimental builds.
60-
- php: '8.2'
61-
phpunit: 'auto'
63+
- php: '8.1'
64+
phpunit: '^10.0'
6265
experimental: true
6366

64-
- php: '8.1'
67+
- php: '8.2'
6568
phpunit: '^10.0'
6669
experimental: true
6770

@@ -86,17 +89,9 @@ jobs:
8689

8790
# Install dependencies and handle caching in one go.
8891
# @link https://github.com/marketplace/actions/install-composer-dependencies
89-
- name: Install Composer dependencies for PHP < 8.2
90-
if: ${{ matrix.php < 8.2 }}
92+
- name: Install Composer dependencies
9193
uses: "ramsey/composer-install@v2"
9294

93-
# For PHP 8.2 and above, we need to install with ignore platform reqs as not all dependencies allow it yet.
94-
- name: Install Composer dependencies for PHP >= 8.2
95-
if: ${{ matrix.php >= 8.2 }}
96-
uses: "ramsey/composer-install@v2"
97-
with:
98-
composer-options: --ignore-platform-reqs
99-
10095
- name: Run the unit tests
10196
if: ${{ matrix.phpunit != '^10.0' }}
10297
run: composer test

0 commit comments

Comments
 (0)