Fix the errors reported by TypeScript 6.0+

Author: dtdesign

package-lock.json

@@ -6,20 +6,20 @@
   "devDependencies": {
     "@eslint/eslintrc": "^3.3.5",
     "@eslint/js": "^10.0.1",
-    "@typescript-eslint/eslint-plugin": "^8.59.4",
-    "@typescript-eslint/parser": "^8.59.4",
-    "esbuild": "^0.28.0",
-    "eslint": "^10.4.0",
+    "@typescript-eslint/eslint-plugin": "^8.61.1",
+    "@typescript-eslint/parser": "^8.61.1",
+    "esbuild": "^0.28.1",
+    "eslint": "^10.5.0",
     "eslint-config-prettier": "^10.1.8",
-    "prettier": "^3.8.3",
+    "prettier": "^3.8.4",
     "typescript": "^6.0.3"
   },
   "dependencies": {
-    "@ckeditor/ckeditor5-inspector": "^5.0.0",
+    "@ckeditor/ckeditor5-inspector": "^5.0.2",
     "@fancyapps/ui": "^6.1.14",
     "@googlemaps/markerclusterer": "2.6.2",
     "@types/facebook-js-sdk": "^3.3.13",
-    "@types/google.maps": "^3.64.1",
+    "@types/google.maps": "^3.65.1",
     "@types/grecaptcha": "^3.0.9",
     "@types/jquery": "^3.5.33",
     "@types/pica": "5.1.3",
@@ -31,7 +31,7 @@
     "@woltlab/visual-dom-diff": "git+https://github.com/WoltLab/visual-dom-diff.git#e5b51fce3157d1eda310566fc1f86101341d1fea",
     "@woltlab/zxcvbn": "git+https://github.com/WoltLab/zxcvbn.git#5b582b24e437f1883ccad3c37dae7c3c5f1e7da3",
     "cropperjs": "2.1.1",
-    "exifreader": "^4.39.1",
+    "exifreader": "^4.41.0",
     "focus-trap": "^8.2.1",
     "hash-wasm": "^4.12.0",
     "html-parsed-element": "^0.4.1",

package.json

@@ -1,3 +1,5 @@
+/// <reference types="grecaptcha" />
+
 /**
  * Handles Google reCaptcha.
  *

ts/WoltLabSuite/Core/Component/Captcha/Recaptcha.ts

@@ -19,10 +19,6 @@ type Mention = {
   icon: string;
 };
 
-type MentionFeed = CKEditor5.MentionFeed & {
-  itemRenderer?: (item: Mention) => HTMLElement | string;
-};
-
 async function getPossibleMentions(query: string): Promise<Mention[]> {
   // Prevent excessive attempts to resolve mentions.
   if (query.length > 24) {
@@ -62,7 +58,7 @@ function getMentionConfiguration(): CKEditor5.MentionConfig {
         },
         marker: "@",
         minimumCharacters: 3,
-      } as unknown as MentionFeed,
+      },
     ],
   };
 }

ts/WoltLabSuite/Core/Component/Ckeditor/Mention.ts

@@ -1,3 +1,5 @@
+/// <reference types="google.maps" />
+
 /**
  * Provides geocoding functions for searching map locations.
  *

ts/WoltLabSuite/Core/Component/GoogleMaps/Geocoding.ts

@@ -25,8 +25,8 @@ export async function addMarker(
     title,
   });
 
-  if (focus) {
-    map.setCenter(marker.position!);
+  if (focus && marker.position !== null && marker.position !== undefined) {
+    map.setCenter(marker.position);
   }
 }
 
@@ -59,7 +59,9 @@ export async function addDraggableMarker(
     gmpClickable: false,
   });
 
-  map.setCenter(marker.position!);
+  if (marker.position !== null && marker.position !== undefined) {
+    map.setCenter(marker.position);
+  }
 
   return marker;
 }

ts/WoltLabSuite/Core/Component/GoogleMaps/Marker.ts

@@ -22,7 +22,7 @@ export class Filter extends EventTarget {
     super();
 
     this.#filterButton = document.getElementById(`${gridId}_filterButton`) as HTMLButtonElement;
-    this.#filterPills = document.getElementById(`${gridId}_filters`) as HTMLElement;
+    this.#filterPills = document.getElementById(`${gridId}_filters`);
 
     this.#setupEventListeners();
   }

ts/WoltLabSuite/Core/Component/GridView/Filter.ts

@@ -32,7 +32,7 @@ export class Selection extends EventTarget {
       this.#change(this.#markAll!.checked);
     });
 
-    this.#selectionBar = document.getElementById(`${gridId}_selectionBar`) as HTMLElement;
+    this.#selectionBar = document.getElementById(`${gridId}_selectionBar`);
     this.#bulkInteractionButton = document.getElementById(`${gridId}_bulkInteractionButton`) as HTMLButtonElement;
     this.#bulkInteractionButton?.addEventListener("click", () => {
       this.#showBulkInteractionMenu();

ts/WoltLabSuite/Core/Component/GridView/Selection.ts

@@ -22,7 +22,7 @@ export class Filter extends EventTarget {
     super();
 
     this.#filterButton = document.getElementById(`${viewId}_filterButton`) as HTMLButtonElement;
-    this.#filterPills = document.getElementById(`${viewId}_filters`) as HTMLElement;
+    this.#filterPills = document.getElementById(`${viewId}_filters`);
 
     this.#setupEventListeners();
   }

ts/WoltLabSuite/Core/Component/ListView/Filter.ts

@@ -32,7 +32,7 @@ export class Selection extends EventTarget {
       this.#change(this.#markAll!.checked);
     });
 
-    this.#selectionBar = document.getElementById(`${viewId}_selectionBar`) as HTMLElement;
+    this.#selectionBar = document.getElementById(`${viewId}_selectionBar`);
     this.#bulkInteractionButton = document.getElementById(`${viewId}_bulkInteractionButton`) as HTMLButtonElement;
     this.#bulkInteractionButton?.addEventListener("click", () => {
       this.#showBulkInteractionMenu();