Skip to content

ES2018 dependent code breaking on older versions of node #419

@HoraceShmorace

Description

@HoraceShmorace

RE: https://github.com/WP-API/node-wpapi/blob/master/wpapi.js#L218

Be careful of breaking changes between minor versions. The spreading of object properties wasn't supported until Node 8.2.1 (with the --harmony flag). Our project is on Node 7.2.1 (for reasons that would only elicit eye rolls), so the upgrade from wpapi 1.1.2 to 1.2x throws a runtime error. We had to switch the package.json semver entry from ^1.1.0 to strict 1.1.2.

For version 1.2.0, your changelog should reflect that the minimum supported Node version is now 8.2.1 (with the --harmony flag).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions