Commit b0b86f9
committed
Fix onboarding UI jank: no full-page Loading flash, no canonicalize double-hop
Two flashes visible in the onboarding flow:
1. create-org flickered 'Create your organization' → 'Loading' → back. The
header was gated on the pending-invitations atom being initial OR waiting,
and that atom is keyed on auth — so the create-org submit (which invalidates
the auth keys) put it into 'waiting' and flipped the whole page to 'Loading'.
Now the create form renders immediately; only the genuine first load shows a
skeleton, and only in the invitations slot. A refetch is 'waiting', not
'initial', so it no longer replaces the page.
2. The connect-MCP step flashed the app sidebar. 'Continue to app' / 'Skip'
navigated to the BARE /{-$orgSlug}, which mounts the shell at / and then
OrgSlugGate fires a SECOND navigation to canonicalize / → /<slug>. That
double hop is the window where the shell paints over the still-mounted
onboarding page. Now it navigates straight to /<slug> (the page already has
the org slug), so the shell mounts once.
Both pre-existing; the new auth-routing flow test (#1006) made them visible.1 parent 1f9bfe0 commit b0b86f9
2 files changed
Lines changed: 21 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
88 | | - | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
89 | 94 | | |
90 | 95 | | |
91 | 96 | | |
| |||
103 | 108 | | |
104 | 109 | | |
105 | 110 | | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
110 | | - | |
| 111 | + | |
111 | 112 | | |
112 | | - | |
| 113 | + | |
113 | 114 | | |
114 | 115 | | |
115 | 116 | | |
116 | 117 | | |
117 | 118 | | |
118 | 119 | | |
119 | 120 | | |
120 | | - | |
| 121 | + | |
121 | 122 | | |
122 | | - | |
| 123 | + | |
123 | 124 | | |
124 | 125 | | |
125 | 126 | | |
| |||
128 | 129 | | |
129 | 130 | | |
130 | 131 | | |
131 | | - | |
| 132 | + | |
132 | 133 | | |
133 | 134 | | |
134 | 135 | | |
| |||
137 | 138 | | |
138 | 139 | | |
139 | 140 | | |
140 | | - | |
141 | | - | |
142 | | - | |
| 141 | + | |
143 | 142 | | |
144 | 143 | | |
145 | 144 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
26 | 32 | | |
27 | 33 | | |
28 | 34 | | |
| |||
150 | 156 | | |
151 | 157 | | |
152 | 158 | | |
153 | | - | |
| 159 | + | |
154 | 160 | | |
155 | 161 | | |
156 | 162 | | |
| |||
160 | 166 | | |
161 | 167 | | |
162 | 168 | | |
163 | | - | |
| 169 | + | |
164 | 170 | | |
165 | 171 | | |
166 | 172 | | |
| |||
0 commit comments