Skip to content

Commit 9b1a2f2

Browse files
committed
Update to latest monaco-vscode-api version and remove themes helpers again
1 parent 8d0d5ff commit 9b1a2f2

11 files changed

Lines changed: 19 additions & 175 deletions

File tree

.eslintrc.cjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ module.exports = {
5353
},
5454
ignorePatterns: [
5555
'**/{node_modules,dist,lib,out,bin}',
56-
'.eslintrc.js',
56+
'.eslintrc.cjs',
5757
'config/header.js',
5858
'packages/examples/*/*.ts'
5959
]

package-lock.json

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/client/package.json

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -23,26 +23,12 @@
2323
".": {
2424
"types": "./lib/index.d.ts",
2525
"default": "./lib/index.js"
26-
},
27-
"./themeRemoteHelper": {
28-
"types": "./lib/helpers/themeRemoteHelper.d.ts",
29-
"default": "./lib/helpers/themeRemoteHelper.js"
30-
},
31-
"./themeLocalHelper": {
32-
"types": "./lib/helpers/themeLocalHelper.d.ts",
33-
"default": "./lib/helpers/themeLocalHelper.js"
3426
}
3527
},
3628
"typesVersions": {
3729
"*": {
3830
".": [
3931
"lib/index.d.ts"
40-
],
41-
"themeRemoteHelper": [
42-
"./lib/helpers/themeRemoteHelper.d.ts"
43-
],
44-
"themeLocalHelper": [
45-
"./lib/helpers/themeLocalHelper.d.ts"
4632
]
4733
}
4834
},
@@ -66,7 +52,7 @@
6652
"vscode-languageclient": "~8.1.0"
6753
},
6854
"peerDependencies": {
69-
"vscode": "npm:@codingame/monaco-vscode-api@~1.76.0"
55+
"vscode": "npm:@codingame/monaco-vscode-api@~1.76.2"
7056
},
7157
"scripts": {
7258
"clean": "npx shx rm -fr lib *.tsbuildinfo",

packages/client/src/helpers/themeHelper.ts

Lines changed: 0 additions & 6 deletions
This file was deleted.

packages/client/src/helpers/themeLocalHelper.ts

Lines changed: 0 additions & 103 deletions
This file was deleted.

packages/client/src/helpers/themeRemoteHelper.ts

Lines changed: 0 additions & 27 deletions
This file was deleted.

packages/client/src/monaco-language-client.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,7 @@ export class MonacoLanguageClient extends BaseLanguageClient {
8181

8282
protected override registerBuiltinFeatures() {
8383
const pendingFullTextDocumentChanges: Map<string, TextDocument> = new Map();
84+
this.registerFeature(new ConfigurationFeature(this));
8485
this.registerFeature(new DidOpenTextDocumentFeature(this, this['_syncedDocuments']));
8586
this.registerFeature(new DidChangeTextDocumentFeature(this, this['_syncedDocuments']));
8687
this['_didChangeTextDocumentFeature'] = new DidChangeTextDocumentFeature(this, pendingFullTextDocumentChanges);
@@ -104,6 +105,7 @@ export class MonacoLanguageClient extends BaseLanguageClient {
104105
this.registerFeature(new RenameFeature(this));
105106
this.registerFeature(new DocumentLinkFeature(this));
106107
this.registerFeature(new ExecuteCommandFeature(this));
108+
this.registerFeature(new SyncConfigurationFeature(this));
107109
this.registerFeature(new TypeDefinitionFeature(this));
108110
this.registerFeature(new ImplementationFeature(this));
109111
this.registerFeature(new ColorProviderFeature(this));
@@ -126,11 +128,9 @@ export class MonacoLanguageClient extends BaseLanguageClient {
126128
* in MonacoLanguageClient. This method is not called!
127129
*/
128130
public registerNotUsedFeatures() {
129-
this.registerFeature(new ConfigurationFeature(this));
130131
this.registerFeature(new WillSaveFeature(this));
131132
this.registerFeature(new WillSaveWaitUntilFeature(this));
132133
this.registerFeature(new DidSaveTextDocumentFeature(this));
133-
this.registerFeature(new SyncConfigurationFeature(this));
134134
this.registerFeature(new WorkspaceSymbolFeature(this));
135135
this.registerFeature(new ProgressFeature(this));
136136
this.registerFeature(new DidCreateFilesFeature(this));

packages/examples/main/package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
"vscode-languageserver": "~8.1.0",
2020
"vscode-uri": "~3.0.7",
2121
"vscode-ws-jsonrpc": "3.0.0",
22-
"vscode-oniguruma": "~1.7.0",
2322
"ws": "~8.13.0"
2423
},
2524
"devDependencies": {

packages/examples/main/src/langium/main.ts

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ import * as monaco from 'monaco-editor/esm/vs/editor/editor.api.js';
1919
import { buildWorkerDefinition } from 'monaco-editor-workers';
2020

2121
import { MonacoLanguageClient, MonacoServices } from 'monaco-languageclient';
22-
import { loadAllDefaultThemes } from 'monaco-languageclient/themeLocalHelper';
2322
import { BrowserMessageReader, BrowserMessageWriter } from 'vscode-languageserver-protocol/browser.js';
2423
import { CloseAction, ErrorAction, MessageTransports } from 'vscode-languageclient';
2524

@@ -42,14 +41,12 @@ const languageId = 'statemachine';
4241
let editorText = '';
4342

4443
const setup = async () => {
45-
const onigFileUrl = new URL('../../../node_modules/vscode-oniguruma/release/onig.wasm', window.location.href).href;
4644
const statemachineLanguageConfig = new URL('../../../node_modules/langium-statemachine-dsl/language-configuration.json', window.location.href).href;
4745
const statemachineTmUrl = new URL('../../../node_modules/langium-statemachine-dsl/syntaxes/statemachine.tmLanguage.json', window.location.href).href;
4846
const exampleStatemachineUrl = new URL('./src/langium/example.statemachine', window.location.href).href;
4947

5048
const responseLanguageConfig = await fetch(statemachineLanguageConfig);
5149
const responseStatemachineTm = await fetch(statemachineTmUrl);
52-
const responseOnig = await fetch(onigFileUrl);
5350
const responseStatemachine = await fetch(exampleStatemachineUrl);
5451
editorText = await responseStatemachine.text();
5552

@@ -62,18 +59,13 @@ const setup = async () => {
6259
...getDialogsServiceOverride(),
6360
...getConfigurationServiceOverride(),
6461
...getKeybindingsServiceOverride(),
65-
...getTextmateServiceOverride(async () => {
66-
return await responseOnig.arrayBuffer();
67-
}),
62+
...getTextmateServiceOverride(),
6863
...getThemeServiceOverride(),
6964
...getTokenClassificationServiceOverride(),
7065
...getLanguageConfigurationServiceOverride(),
7166
...getLanguagesServiceOverride()
7267
});
7368

74-
// IMPORTANT: Please run 'npm run fetch:themes' otherwise the themes are not available
75-
loadAllDefaultThemes('./resources/themes');
76-
7769
setLanguages([{
7870
id: languageId,
7971
extensions: [
@@ -101,9 +93,9 @@ const setup = async () => {
10193
});
10294

10395
updateUserConfiguration(`{
104-
"workbench.colorTheme": "Dark+ (Experimental)",
10596
"editor.fontSize": 14
10697
}`);
98+
10799
};
108100

109101
const run = async () => {

tsconfig.json

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,9 @@
4444
"**/packages/*/*/*.ts",
4545
"**/packages/*/*/*.js",
4646
"**/resources/**/*.mts",
47-
"**/resources/**/*.mjs"
48-
, "packages/examples/main/resources/fetchThemes.jts" ],
47+
"**/resources/**/*.mjs",
48+
"*.ts"
49+
],
4950
"exclude": [
5051
"dist/**/*",
5152
"lib/**/*",

0 commit comments

Comments
 (0)