Skip to content

Commit 42037d3

Browse files
pieternTanishqDatabricks
authored andcommitted
acceptance: forbid empty test.toml files (databricks#5297)
Fail any acceptance test whose `test.toml` parses to an empty table (zero-byte or comment-only). The check lives in the acceptance test runner's config loader. Deletes 20 pre-existing offenders -- 4 zero-byte placeholders and 16 comment-only files. None of the comments in those files are relevant for the test. This codifies a review comment that shows up from time to time and thereby removes ambiguity/overhead. This pull request and its description were written by Isaac.
1 parent 670c33a commit 42037d3

21 files changed

Lines changed: 4 additions & 17 deletions

File tree

acceptance/apps/deploy/test.toml

Lines changed: 0 additions & 1 deletion
This file was deleted.

acceptance/bundle/artifacts/whl_prebuilt_outside/test.toml

Whitespace-only changes.

acceptance/bundle/deploy/experimental-python/test.toml

Lines changed: 0 additions & 1 deletion
This file was deleted.

acceptance/bundle/deploy/python-notebook/test.toml

Lines changed: 0 additions & 1 deletion
This file was deleted.

acceptance/bundle/resources/postgres_branches/basic/test.toml

Lines changed: 0 additions & 1 deletion
This file was deleted.

acceptance/bundle/resources/postgres_branches/replace_existing/test.toml

Lines changed: 0 additions & 1 deletion
This file was deleted.

acceptance/bundle/resources/postgres_branches/update_protected/test.toml

Lines changed: 0 additions & 1 deletion
This file was deleted.

acceptance/bundle/resources/postgres_branches/without_branch_id/test.toml

Lines changed: 0 additions & 1 deletion
This file was deleted.

acceptance/bundle/resources/postgres_endpoints/basic/test.toml

Lines changed: 0 additions & 1 deletion
This file was deleted.

acceptance/bundle/resources/postgres_endpoints/replace_existing/test.toml

Lines changed: 0 additions & 1 deletion
This file was deleted.

0 commit comments

Comments
 (0)