use test id to locate element

Author: birkskyum

e2e/react-router/basic-file-based/src/routes/hover-preload-hash.tsx

@@ -5,16 +5,13 @@ export const Route = createFileRoute('/hover-preload-hash')({
 })
 
 function Page() {
-  return (
-    <>
-      <div className="p-2">Hello from About!</div>
-      <Link
-        to="/hover-preload-hash"
-        hash={'position1'}
-        className="[&.active]:font-bold"
-      >
-        To hash
-      </Link>
+  
+    return <>
+    
+    <div className="p-2">Hello from About!</div>
+    <Link to="/hover-preload-hash" hash={"position1"} className="[&.active]:font-bold" data-testid="link-to-hash">
+          To hash
+    </Link>
 
       <p>
         Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy

e2e/react-router/basic-file-based/tests/hover-preload-hash.spec.ts

@@ -8,7 +8,7 @@ test('clicking hash link then hovering another link does not scroll back to hash
   await page.goto(toRuntimePath('/hover-preload-hash'))
 
   // Click the hash link to navigate to position1
-  await page.getByRole('link', { name: 'To hash' }).click()
+  await page.getByTestId('link-to-hash').click()
   await expect(page.locator('#position1')).toBeInViewport()
 
   // Scroll up so position1 is no longer in view

e2e/solid-router/basic-file-based/src/routes/hover-preload-hash.tsx

@@ -5,16 +5,13 @@ export const Route = createFileRoute('/hover-preload-hash')({
 })
 
 function Page() {
-  return (
-    <>
-      <div class="p-2">Hello from About!</div>
-      <Link
-        to="/hover-preload-hash"
-        hash={'position1'}
-        class="[&.active]:font-bold"
-      >
-        To hash
-      </Link>
+  
+    return <>
+    
+    <div class="p-2">Hello from About!</div>
+    <Link to="/hover-preload-hash" hash={"position1"} class="[&.active]:font-bold" data-testid="link-to-hash">
+          To hash
+    </Link>
 
       <p>
         Lorem ipsum dolor sit amet, consetetur sadipscing elitr, sed diam nonumy

e2e/solid-router/basic-file-based/tests/hover-preload-hash.spec.ts

@@ -8,7 +8,7 @@ test('clicking hash link then hovering another link does not scroll back to hash
   await page.goto(toRuntimePath('/hover-preload-hash'))
 
   // Click the hash link to navigate to position1
-  await page.getByRole('link', { name: 'To hash' }).click()
+  await page.getByTestId('link-to-hash').click()
   await expect(page.locator('#position1')).toBeInViewport()
 
   // Scroll up so position1 is no longer in view