fix: track data property if promise is tracked

TkDodo · TkDodo · commit d1184babd1ba · 2024-09-02T16:24:13.000+02:00
if users use the `promise` returned from useQuery, they are actually interested in the `data` it unwraps to. Since the promise doesn't change when data resolves, we would likely miss a re-render
diff --git a/packages/query-core/src/queryObserver.ts b/packages/query-core/src/queryObserver.ts
@@ -680,6 +680,9 @@ export class QueryObserver<
       if (this.options.throwOnError) {
         includedProps.add('error')
       }
+      if (includedProps.has('promise')) {
+        includedProps.add('data')
+      }
 
       return Object.keys(this.#currentResult).some((key) => {
         const typedKey = key as keyof QueryObserverResult

Original file line number	Diff line number	Diff line change
`@@ -680,6 +680,9 @@ export class QueryObserver<`
`680`	`680`	`if (this.options.throwOnError) {`
`681`	`681`	`includedProps.add('error')`
`682`	`682`	`}`
	`683`	`+ if (includedProps.has('promise')) {`
	`684`	`+ includedProps.add('data')`
	`685`	`+ }`
`683`	`686`
`684`	`687`	`return Object.keys(this.#currentResult).some((key) => {`
`685`	`688`	`const typedKey = key as keyof QueryObserverResult`