Commit 69bceb1
fix: address CodeRabbit findings + e2e structured-output renderer
- e2e ChatUI: render `structured-output` parts so the assistant message
has visible text content. The Phase 1 redesign routes structured-output
JSON deltas into a dedicated part instead of a text part, so the e2e
selector `getLastAssistantMessage` was returning an empty string and the
structured-output-stream specs failed.
- processor: reconcile cumulative `chunk.content` against the existing
StructuredOutputPart.raw before appending, mirroring the dedup the text
path already does. Adapters that emit cumulative content (rather than
incremental delta) on a structured run would otherwise duplicate the
JSON buffer and corrupt the partial parse. Adds a focused unit test.
- example: fix the recipe metadata block in /generations/structured-chat
so a valid `estimatedCostUsd === 0` renders `$0.00` instead of being
hidden by a truthy check. Minor CodeRabbit catch.
The remaining CodeRabbit findings were either stale (raw fallback already
addressed in the prior fix commit) or pre-existing (initialMessages
mount-only hydration was on main before this branch — out of scope).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent 640c3b4 commit 69bceb1
4 files changed
Lines changed: 80 additions & 7 deletions
File tree
- examples/ts-react-chat/src/routes
- packages/typescript/ai
- src/activities/chat/stream
- tests
- testing/e2e/src/components
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
189 | | - | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
190 | 192 | | |
191 | 193 | | |
192 | 194 | | |
193 | | - | |
| 195 | + | |
194 | 196 | | |
195 | 197 | | |
196 | 198 | | |
| |||
Lines changed: 22 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
855 | 855 | | |
856 | 856 | | |
857 | 857 | | |
858 | | - | |
859 | | - | |
860 | | - | |
861 | | - | |
862 | | - | |
| 858 | + | |
| 859 | + | |
| 860 | + | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
| 864 | + | |
| 865 | + | |
| 866 | + | |
| 867 | + | |
| 868 | + | |
| 869 | + | |
| 870 | + | |
| 871 | + | |
| 872 | + | |
| 873 | + | |
| 874 | + | |
| 875 | + | |
| 876 | + | |
| 877 | + | |
| 878 | + | |
| 879 | + | |
863 | 880 | | |
864 | 881 | | |
865 | 882 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3551 | 3551 | | |
3552 | 3552 | | |
3553 | 3553 | | |
| 3554 | + | |
| 3555 | + | |
| 3556 | + | |
| 3557 | + | |
| 3558 | + | |
| 3559 | + | |
| 3560 | + | |
| 3561 | + | |
| 3562 | + | |
| 3563 | + | |
| 3564 | + | |
| 3565 | + | |
| 3566 | + | |
| 3567 | + | |
| 3568 | + | |
| 3569 | + | |
| 3570 | + | |
| 3571 | + | |
| 3572 | + | |
| 3573 | + | |
| 3574 | + | |
| 3575 | + | |
| 3576 | + | |
| 3577 | + | |
| 3578 | + | |
| 3579 | + | |
| 3580 | + | |
| 3581 | + | |
| 3582 | + | |
| 3583 | + | |
| 3584 | + | |
| 3585 | + | |
| 3586 | + | |
| 3587 | + | |
3554 | 3588 | | |
3555 | 3589 | | |
3556 | 3590 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
158 | 158 | | |
159 | 159 | | |
160 | 160 | | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
161 | 181 | | |
162 | 182 | | |
163 | 183 | | |
| |||
0 commit comments