Avoid sending invalid location errors to telemetry (#3682)

Author: vinistock

lib/ruby_lsp/server.rb

@@ -126,8 +126,12 @@ def process_message(message)
       if message[:id]
         # If a document is deleted before we are able to process all of its enqueued requests, we will try to read it
         # from disk and it raise this error. This is expected, so we don't include the `data` attribute to avoid
-        # reporting these to our telemetry
-        if e.is_a?(Store::NonExistingDocumentError)
+        # reporting these to our telemetry.
+        #
+        # Similarly, if we receive a location for an invalid position in the
+        # document, we don't report it to telemetry
+        case e
+        when Store::NonExistingDocumentError, Document::InvalidLocationError
           send_message(Error.new(
             id: message[:id],
             code: Constant::ErrorCodes::INVALID_PARAMS,

test/server_test.rb

@@ -1567,6 +1567,38 @@ def version
     end
   end
 
+  def test_invalid_location_errors_are_not_reported_to_telemetry
+    uri = URI::Generic.from_path(path: "/foo.rb")
+
+    @server.process_message({
+      method: "textDocument/didOpen",
+      params: {
+        textDocument: {
+          uri: uri,
+          text: "class Foo\nend",
+          version: 1,
+          languageId: "ruby",
+        },
+      },
+    })
+
+    @server.push_message({
+      id: 1,
+      method: "textDocument/definition",
+      params: {
+        textDocument: {
+          uri: uri,
+        },
+        position: { line: 10, character: 6 },
+      },
+    })
+
+    error = find_message(RubyLsp::Error)
+    attributes = error.to_hash[:error]
+    assert_nil(attributes[:data])
+    assert_match("Document::InvalidLocationError", attributes[:message])
+  end
+
   private
 
   def wait_for_indexing