fix(powerx): harden window epochs, sources footer, and zoomed-out dim overlay | PowerX：加固窗口时间戳校验、来源脚注与缩放后的置灰遮罩

Review fixes for #931:
- reject implausible unix-second window bounds (garbage/ms-scale epochs)
  in windowFromUnixPair and format window bounds defensively, so a corrupt
  sidecar can never crash the page with a Date RangeError
- credit an artifact in the power block's sources footer only when its
  parsed content actually contributed (no-op bmk agg rows fall through to
  the Tier-2 bundle agg fallback)
- keep the warmup/post-benchmark dim overlay when the chart is zoomed
  wholly outside the measurement window instead of dropping all shading
- stop mapping the validation sidecar's own schema_version into
  published.power_metric_schema_version (different versioning axis)

Author: edwingao28

packages/app/src/app/api/gpu-metrics/route.test.ts

@@ -530,6 +530,37 @@ describe('GET /api/gpu-metrics', () => {
       });
     });
 
+    it('keeps a no-op bmk artifact out of sources and falls through to the bundle', async () => {
+      zipRegistry.set('zip:bmk-noop', [
+        // Agg row with no power fields at all (e.g. an eval-style row).
+        { entryName: 'agg_dsr1_h200.json', contents: JSON.stringify({ output_toks_per_sec: 1 }) },
+      ]);
+      zipRegistry.set('zip:audit-sidecar-only', [
+        { entryName: 'power_validation_dsr1_h200.json', contents: SIDECAR_JSON },
+      ]);
+      installFetch([
+        { id: 1, name: 'gpu_metrics_dsr1_h200' },
+        { id: 2, name: 'bmk_dsr1_h200', zipKey: 'zip:bmk-noop' },
+        { id: 3, name: 'power_audit_dsr1_h200', zipKey: 'zip:audit-sidecar-only' },
+      ]);
+
+      const res = await GET(req('/api/gpu-metrics?runId=12345'));
+      expect(res.status).toBe(200);
+      const body = await res.json();
+      // The bmk artifact contributed nothing, so only the bundle is credited.
+      expect(body.artifacts[0].power.sources).toEqual(['power_audit_dsr1_h200']);
+      expect(body.artifacts[0].power.published).toEqual({
+        avg_power_w: 401.5,
+        avg_total_gpu_power_w: 3212,
+        power_metric_schema_version: null,
+        source: 'validation_metrics',
+      });
+      expect(body.artifacts[0].power.window).toEqual({
+        start_unix: 1755000020,
+        end_unix: 1755000080,
+      });
+    });
+
     it('omits power but keeps the CSV view when the sidecar JSON is malformed', async () => {
       const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {});
       try {

packages/app/src/app/api/gpu-metrics/route.ts

@@ -16,6 +16,7 @@ import {
   type GithubWorkflowRun,
 } from '@/lib/github-artifacts';
 import {
+  hasPowerContent,
   mergeArtifactPower,
   powerFromAggRow,
   powerFromValidationSidecar,
@@ -94,8 +95,13 @@ async function resolveArtifactPower(
       const aggRow =
         findNamedAggEntry(entries, suffix) ?? (entries.length === 1 ? entries[0].json : null);
       if (aggRow) {
-        fromAgg = powerFromAggRow(aggRow, 'bmk_artifact');
-        sources.push(bmkArtifact.name);
+        const parsed = powerFromAggRow(aggRow, 'bmk_artifact');
+        // A row with no power fields contributes nothing: keep it out of the
+        // sources footer and let Tier 2's agg fallback take over.
+        if (hasPowerContent(parsed)) {
+          fromAgg = parsed;
+          sources.push(bmkArtifact.name);
+        }
       }
     }
   }
@@ -107,14 +113,20 @@ async function resolveArtifactPower(
     const entries = await downloadJsonEntries(auditArtifact, githubToken);
     if (entries) {
       const sidecar = selectValidationEntry(entries, suffix);
-      if (sidecar) fromSidecar = powerFromValidationSidecar(sidecar);
+      const parsedSidecar = sidecar ? powerFromValidationSidecar(sidecar) : null;
+      if (hasPowerContent(parsedSidecar)) fromSidecar = parsedSidecar;
+      let bundleAggContributed = false;
       if (!fromAgg) {
         const aggRow = findNamedAggEntry(entries, suffix);
-        if (aggRow) fromAgg = powerFromAggRow(aggRow, 'power_audit_agg');
-      }
-      if (sidecar || fromAgg?.published?.source === 'power_audit_agg') {
-        sources.push(auditArtifact.name);
+        if (aggRow) {
+          const parsed = powerFromAggRow(aggRow, 'power_audit_agg');
+          if (hasPowerContent(parsed)) {
+            fromAgg = parsed;
+            bundleAggContributed = true;
+          }
+        }
       }
+      if (fromSidecar || bundleAggContributed) sources.push(auditArtifact.name);
     }
   }
 

packages/app/src/components/gpu-power/GpuPowerChart.tsx

@@ -113,9 +113,10 @@ function drawMeasurementWindow(
   if (!aligned || width <= 0) return;
 
   const clampX = (x: number) => Math.max(0, Math.min(width, x));
-  const xStart = clampX(xScale(aligned.startSeconds));
-  const xEnd = clampX(xScale(aligned.endSeconds));
-  if (xEnd <= xStart) return;
+  const rawStart = xScale(aligned.startSeconds);
+  const rawEnd = xScale(aligned.endSeconds);
+  const xStart = clampX(rawStart);
+  const xEnd = clampX(rawEnd);
 
   const windowGroup = group
     .insert('g', ':first-child')
@@ -135,30 +136,31 @@ function drawMeasurementWindow(
       .text(text);
   };
 
-  // Dimmed warmup/post regions outside the formal window
-  if (xStart > 0) {
-    windowGroup
-      .append('rect')
-      .attr('x', 0)
-      .attr('y', 0)
-      .attr('width', xStart)
-      .attr('height', height)
-      .attr('fill', DIM_COLOR)
-      .attr('opacity', 0.05);
-    addRegionLabel(0, xStart, labels.warmup, DIM_COLOR);
-  }
-  if (xEnd < width) {
+  const addDimRegion = (x0: number, x1: number, text: string) => {
     windowGroup
       .append('rect')
-      .attr('x', xEnd)
+      .attr('x', x0)
       .attr('y', 0)
-      .attr('width', width - xEnd)
+      .attr('width', x1 - x0)
       .attr('height', height)
       .attr('fill', DIM_COLOR)
       .attr('opacity', 0.05);
-    addRegionLabel(xEnd, width, labels.after, DIM_COLOR);
+    addRegionLabel(x0, x1, text, DIM_COLOR);
+  };
+
+  if (xEnd <= xStart) {
+    // Visible x-range lies wholly on one side of the window (deep zoom into
+    // warmup or post-benchmark): keep the dim overlay so the region is not
+    // mistaken for measured data.
+    if (rawEnd <= 0) addDimRegion(0, width, labels.after);
+    else if (rawStart >= width) addDimRegion(0, width, labels.warmup);
+    return;
   }
 
+  // Dimmed warmup/post regions outside the formal window
+  if (xStart > 0) addDimRegion(0, xStart, labels.warmup);
+  if (xEnd < width) addDimRegion(xEnd, width, labels.after);
+
   // Measurement window band + dashed boundary lines
   windowGroup
     .append('rect')

packages/app/src/components/gpu-power/GpuPowerDisplay.tsx

@@ -152,6 +152,12 @@ const DELTA_LEVEL_CLASSES = {
   alert: 'text-red-700 dark:text-red-300',
 } as const;
 
+/** ISO-format a unix-seconds window bound; Date throws outside ±8.64e15 ms. */
+function formatWindowBound(unixSeconds: number): string {
+  const ms = unixSeconds * 1000;
+  return Math.abs(ms) <= 8.64e15 ? new Date(ms).toISOString() : String(unixSeconds);
+}
+
 type GpuMetricsView = 'chart' | 'correlation';
 
 const GPU_METRICS_VIEW_OPTIONS: SegmentedToggleOption<GpuMetricsView>[] = [
@@ -562,8 +568,8 @@ export default function GpuMetricsDisplay() {
                       <div className="flex flex-wrap gap-x-6 gap-y-1 text-sm mb-2">
                         <span>
                           <span className="text-muted-foreground">{t.windowLabel}</span>{' '}
-                          {new Date(window.start_unix * 1000).toISOString()} →{' '}
-                          {new Date(window.end_unix * 1000).toISOString()}
+                          {formatWindowBound(window.start_unix)} →{' '}
+                          {formatWindowBound(window.end_unix)}
                         </span>
                         <span>
                           <span className="text-muted-foreground">{t.windowDurationLabel}</span>{' '}

packages/app/src/lib/api-route-catalog.ts

@@ -56,7 +56,7 @@ export const apiRouteCatalog = [
     },
     // 2026-08: additive optional `power` block assembled from same-suffix
     // bmk_*/power_audit_* sibling artifacts; still a UI-only unstable shape.
-    sourceSha256: 'e2e860cca7365a49fa56e39657a2e7d272a061544415f3adcf445a5a24f94e3c',
+    sourceSha256: 'a752682622d9685ab7f76a1bd0d49d94df4dcc659fde36e62d56681f6146df7a',
   },
   {
     source: 'src/app/api/openapi.json/route.ts',

packages/app/src/lib/power-audit-artifacts.test.ts

@@ -1,6 +1,7 @@
 import { describe, expect, it } from 'vitest';
 
 import {
+  hasPowerContent,
   mergeArtifactPower,
   powerFromAggRow,
   powerFromValidationSidecar,
@@ -108,6 +109,25 @@ describe('powerFromAggRow', () => {
   it('returns an empty partial for a row with no power fields', () => {
     expect(powerFromAggRow({ output_toks_per_sec: 1000 })).toEqual({});
   });
+
+  it('rejects implausible window epochs (garbage, ms-scale, non-positive)', () => {
+    // 1e16 s → new Date(1e19 ms) would throw RangeError in the client render.
+    expect(
+      powerFromAggRow({
+        power_audit: { window_start_unix: 1e16, window_end_unix: 1e16 + 60 },
+      }).window,
+    ).toBeUndefined();
+    expect(
+      powerFromAggRow({
+        power_audit: { window_start_unix: 1_755_000_020_000, window_end_unix: 1_755_000_080_000 },
+      }).window,
+    ).toBeUndefined();
+    expect(
+      powerFromAggRow({
+        power_audit: { window_start_unix: -5, window_end_unix: 1_755_000_080 },
+      }).window,
+    ).toBeUndefined();
+  });
 });
 
 // ---------------------------------------------------------------------------
@@ -138,11 +158,21 @@ describe('powerFromValidationSidecar', () => {
     expect(result.published).toEqual({
       avg_power_w: 401.25,
       avg_total_gpu_power_w: 3210,
-      power_metric_schema_version: 1,
+      // The sidecar's own schema_version is a different versioning axis than
+      // the agg row's power_metric_schema_version — never mapped through.
+      power_metric_schema_version: null,
       source: 'validation_metrics',
     });
   });
 
+  it('rejects implausible window epochs in the sidecar', () => {
+    expect(
+      powerFromValidationSidecar({
+        benchmark_window: { start_time_unix: 1_755_000_020_000, end_time_unix: 1_755_000_080_000 },
+      }).window,
+    ).toBeUndefined();
+  });
+
   it('maps an invalid verdict with reasons', () => {
     const result = powerFromValidationSidecar({
       power_valid: false,
@@ -252,6 +282,19 @@ describe('selectValidationEntry', () => {
   });
 });
 
+// ---------------------------------------------------------------------------
+// hasPowerContent
+// ---------------------------------------------------------------------------
+
+describe('hasPowerContent', () => {
+  it('distinguishes empty partials from ones carrying a power field', () => {
+    expect(hasPowerContent(null)).toBe(false);
+    expect(hasPowerContent({})).toBe(false);
+    expect(hasPowerContent({ power_valid: 1 })).toBe(true);
+    expect(hasPowerContent(powerFromAggRow({ output_toks_per_sec: 1000 }))).toBe(false);
+  });
+});
+
 // ---------------------------------------------------------------------------
 // mergeArtifactPower
 // ---------------------------------------------------------------------------

packages/app/src/lib/power-audit-artifacts.ts

@@ -46,10 +46,17 @@ function asRecord(value: unknown): Record<string, unknown> | null {
     : null;
 }
 
+// Upper bound on plausible unix-second epochs (2100-01-01T00:00:00Z). Rejects
+// ms-scale and garbage values, and keeps bound*1000 inside Date's ±8.64e15 ms
+// representable range so the client can always ISO-format the window.
+const MAX_UNIX_SECONDS = 4_102_444_800;
+
 function windowFromUnixPair(start: unknown, end: unknown): PowerWindow | null {
   const startUnix = asFiniteNumber(start);
   const endUnix = asFiniteNumber(end);
   if (startUnix === null || endUnix === null) return null;
+  if (startUnix <= 0 || endUnix <= 0) return null;
+  if (startUnix > MAX_UNIX_SECONDS || endUnix > MAX_UNIX_SECONDS) return null;
   return { start_unix: startUnix, end_unix: endUnix };
 }
 
@@ -141,7 +148,9 @@ export function powerFromValidationSidecar(
       result.published = {
         avg_power_w: avgPowerW,
         avg_total_gpu_power_w: avgTotalGpuPowerW,
-        power_metric_schema_version: asFiniteNumber(sidecar.schema_version),
+        // The sidecar's schema_version versions the sidecar itself, a
+        // different axis than the agg row's power_metric_schema_version.
+        power_metric_schema_version: null,
         source: 'validation_metrics',
       };
     }
@@ -195,7 +204,8 @@ export function selectValidationEntry(
   return null;
 }
 
-function hasContent(
+/** True when a mapped partial carries at least one power field. */
+export function hasPowerContent(
   partial: Partial<GpuArtifactPower> | null,
 ): partial is Partial<GpuArtifactPower> {
   return partial !== null && Object.keys(partial).length > 0;
@@ -212,7 +222,7 @@ export function mergeArtifactPower(
   fromSidecar: Partial<GpuArtifactPower> | null,
   sources: string[],
 ): GpuArtifactPower | null {
-  if (!hasContent(fromAgg) && !hasContent(fromSidecar)) return null;
+  if (!hasPowerContent(fromAgg) && !hasPowerContent(fromSidecar)) return null;
   const agg = fromAgg ?? {};
   const sidecar = fromSidecar ?? {};