[rb] apply review feedback: BiDi contexts, DRY browsers, uninstall example, zip_file alias

Author: titusfortner

rb/lib/selenium/webdriver/common/zipper.rb

@@ -65,6 +65,9 @@ def zip_root(path)
           encode_zip(path, File.dirname(path))
         end
 
+        # Backwards-compatible name for the file-only behavior #zip_root now subsumes.
+        alias zip_file zip_root
+
         private
 
         def encode_zip(path, base)

rb/sig/lib/selenium/webdriver/common/zipper.rbs

@@ -29,6 +29,8 @@ module Selenium
 
       def self.zip_root: (untyped path) -> untyped
 
+      alias self.zip_file self.zip_root
+
       private
 
       def self.encode_zip: (untyped path, untyped base) -> untyped

rb/spec/integration/selenium/webdriver/BUILD.bazel

@@ -46,7 +46,7 @@ _BIDI_IMPLEMENTATIONS = [
     "navigation_spec.rb",
 ]
 
-# bidi implementations that must also run over a Grid (e.g. se/file upload of an unpacked extension)
+# bidi implementations that must also run over a Grid
 _GRID_BIDI = [
     "driver_spec.rb",
 ]

rb/spec/integration/selenium/webdriver/chrome/BUILD.bazel

@@ -1,5 +1,10 @@
 load("//rb/spec:tests.bzl", "rb_integration_test")
 
+_BROWSERS = [
+    "chrome",
+    "chrome-beta",
+]
+
 filegroup(
     name = "all_srcs",
     testonly = True,
@@ -11,10 +16,7 @@ filegroup(
     rb_integration_test(
         name = file[:-8],
         srcs = [file],
-        browsers = [
-            "chrome",
-            "chrome-beta",
-        ],
+        browsers = _BROWSERS,
         data = ["//common/extensions"],
     )
     for file in glob(
@@ -30,19 +32,13 @@ rb_integration_test(
     name = "driver",
     srcs = ["driver_spec.rb"],
     bidi = True,
-    browsers = [
-        "chrome",
-        "chrome-beta",
-    ],
+    browsers = _BROWSERS,
     data = ["//common/extensions"],
 )
 
 rb_integration_test(
     name = "service",
     srcs = ["service_spec.rb"],
-    browsers = [
-        "chrome",
-        "chrome-beta",
-    ],
+    browsers = _BROWSERS,
     grid = False,
 )