fix: Media permissions (#1740)

* Ask for media access on MacOS

* Update Snap plugs

Author: tassoevan

electron-builder.json

@@ -26,7 +26,7 @@
       "NSMicrophoneUsageDescription": "I need access to your microphone to record the audio you want to send.",
       "NSCameraUsageDescription": "I need access to your camera to record the video you want to send."
     },
-    "hardenedRuntime" : true,
+    "hardenedRuntime": true,
     "gatekeeperAssess": false,
     "provisioningProfile": "embedded.provisionprofile"
   },
@@ -53,7 +53,7 @@
   "mas": {
     "entitlements": "build/entitlements.mas.plist",
     "entitlementsInherit": "build/entitlements.mas.inherit.plist",
-    "hardenedRuntime" : true,
+    "hardenedRuntime": true,
     "asarUnpack": [
       "node_modules"
     ],
@@ -66,33 +66,33 @@
     ],
     "icon": "build/icon.ico",
     "publisherName": "Sectigo RSA Code Signing CA",
-		"legalTrademarks": "",
-		"verifyUpdateCodeSignature": true,
-		"requestedExecutionLevel": "asInvoker",
-		"signAndEditExecutable": true,
-		"signDlls": false
+    "legalTrademarks": "",
+    "verifyUpdateCodeSignature": true,
+    "requestedExecutionLevel": "asInvoker",
+    "signAndEditExecutable": true,
+    "signDlls": false
   },
   "nsis": {
     "oneClick": false,
     "perMachine": false,
     "allowElevation": true,
     "allowToChangeInstallationDirectory": true,
     "installerIcon": "build/installerIcon.ico",
-		"uninstallerIcon": "build/uninstallerIcon.ico",
-		"installerSidebar": "build/installerSidebar.bmp",
-		"uninstallerSidebar": "build/uninstallerSidebar.bmp",
-		"uninstallDisplayName": "${productName} ${version}",
-		"include": "build/installer.nsh",
-		"license": "LICENSE",
-		"artifactName": "rocketchat-setup-${version}.${ext}",
-		"deleteAppDataOnUninstall": false,
-		"displayLanguageSelector": false,
-		"unicode": true,
-		"warningsAsErrors": true,
-		"runAfterFinish": true,
-		"createDesktopShortcut": "always",
-		"createStartMenuShortcut": true,
-		"menuCategory": false
+    "uninstallerIcon": "build/uninstallerIcon.ico",
+    "installerSidebar": "build/installerSidebar.bmp",
+    "uninstallerSidebar": "build/uninstallerSidebar.bmp",
+    "uninstallDisplayName": "${productName} ${version}",
+    "include": "build/installer.nsh",
+    "license": "LICENSE",
+    "artifactName": "rocketchat-setup-${version}.${ext}",
+    "deleteAppDataOnUninstall": false,
+    "displayLanguageSelector": false,
+    "unicode": true,
+    "warningsAsErrors": true,
+    "runAfterFinish": true,
+    "createDesktopShortcut": "always",
+    "createStartMenuShortcut": true,
+    "menuCategory": false
   },
   "msi": {
     "artifactName": "rocketchat-setup-${version}.${ext}"
@@ -131,7 +131,23 @@
   },
   "snap": {
     "artifactName": "rocketchat_${version}_${arch}.${ext}",
-    "plugs": ["desktop", "desktop-legacy", "home", "x11", "unity7", "browser-support", "network", "gsettings", "pulseaudio", "opengl", "camera"]
+    "plugs": [
+      "desktop",
+      "desktop-legacy",
+      "home",
+      "x11",
+      "unity7",
+      "browser-support",
+      "network",
+      "gsettings",
+      "pulseaudio",
+      "opengl",
+      "camera",
+      "audio-playback",
+      "audio-record",
+      "screen-inhibit-control",
+      "upower-observe"
+    ]
   },
   "afterSign": "./build/notarize.js",
   "publish": [

src/ui/main/webviews.ts

@@ -15,6 +15,7 @@ import {
   Session,
   session,
   shell,
+  systemPreferences,
   UploadBlob,
   UploadFile,
   UploadRawData,
@@ -427,9 +428,21 @@ export const attachGuestWebContentsEvents = (rootWindow: BrowserWindow): void =>
   });
 
   const webviewsSession = session.fromPartition('persist:rocketchat-server');
-  webviewsSession.setPermissionRequestHandler((_webContents, permission, callback, details) => {
+  webviewsSession.setPermissionRequestHandler(async (_webContents, permission, callback, details) => {
     switch (permission) {
-      case 'media':
+      case 'media': {
+        if (process.platform !== 'darwin') {
+          callback(true);
+          return;
+        }
+
+        const { mediaTypes } = details;
+        const allowed = (!mediaTypes.includes('audio') || await systemPreferences.askForMediaAccess('microphone'))
+          && (!mediaTypes.includes('video') || await systemPreferences.askForMediaAccess('camera'));
+        callback(allowed);
+        return;
+      }
+
       case 'geolocation':
       case 'notifications':
       case 'midiSysex':
@@ -438,9 +451,11 @@ export const attachGuestWebContentsEvents = (rootWindow: BrowserWindow): void =>
         callback(true);
         return;
 
-      case 'openExternal':
-        isProtocolAllowed(details.externalURL).then(callback);
+      case 'openExternal': {
+        const allowed = await isProtocolAllowed(details.externalURL);
+        callback(allowed);
         return;
+      }
 
       default:
         callback(false);