Skip to content

Commit 3bd34bb

Browse files
committed
Fix tests to match the changes
1 parent 604155f commit 3bd34bb

5 files changed

Lines changed: 13 additions & 21 deletions

File tree

class_generator/tests/manifests/Deployment/deployment.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,11 +73,11 @@ def to_dict(self) -> None:
7373
super().to_dict()
7474

7575
if not self.kind_dict and not self.yaml_file:
76-
if not all([
77-
self.selector,
78-
self.template,
79-
]):
80-
raise MissingRequiredArgumentError(argument="selector, template")
76+
if not self.selector:
77+
raise MissingRequiredArgumentError(argument="self.selector")
78+
79+
if not self.template:
80+
raise MissingRequiredArgumentError(argument="self.template")
8181

8282
self.res["spec"] = {}
8383
_spec = self.res["spec"]

class_generator/tests/manifests/Image/image_caching_internal_knative_dev.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,8 @@ def to_dict(self) -> None:
4646
super().to_dict()
4747

4848
if not self.kind_dict and not self.yaml_file:
49-
if not all([
50-
self.image,
51-
]):
52-
raise MissingRequiredArgumentError(argument="image")
49+
if not self.image:
50+
raise MissingRequiredArgumentError(argument="self.image")
5351

5452
self.res["spec"] = {}
5553
_spec = self.res["spec"]

class_generator/tests/manifests/Pod/pod.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -329,10 +329,8 @@ def to_dict(self) -> None:
329329
super().to_dict()
330330

331331
if not self.kind_dict and not self.yaml_file:
332-
if not all([
333-
self.containers,
334-
]):
335-
raise MissingRequiredArgumentError(argument="containers")
332+
if not self.containers:
333+
raise MissingRequiredArgumentError(argument="self.containers")
336334

337335
self.res["spec"] = {}
338336
_spec = self.res["spec"]

class_generator/tests/manifests/ServiceMeshMember/service_mesh_member.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,8 @@ def to_dict(self) -> None:
2929
super().to_dict()
3030

3131
if not self.kind_dict and not self.yaml_file:
32-
if not all([
33-
self.control_plane_ref,
34-
]):
35-
raise MissingRequiredArgumentError(argument="control_plane_ref")
32+
if not self.control_plane_ref:
33+
raise MissingRequiredArgumentError(argument="self.control_plane_ref")
3634

3735
self.res["spec"] = {}
3836
_spec = self.res["spec"]

class_generator/tests/manifests/ServingRuntime/serving_runtime.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -97,10 +97,8 @@ def to_dict(self) -> None:
9797
super().to_dict()
9898

9999
if not self.kind_dict and not self.yaml_file:
100-
if not all([
101-
self.containers,
102-
]):
103-
raise MissingRequiredArgumentError(argument="containers")
100+
if not self.containers:
101+
raise MissingRequiredArgumentError(argument="self.containers")
104102

105103
self.res["spec"] = {}
106104
_spec = self.res["spec"]

0 commit comments

Comments
 (0)