Merge pull request #8976 from QwikDev/fix-updates-after-error

fix: keep sibling updates running after uncaught render errors

Author: maiieul

.changeset/tidy-errors-continue.md

@@ -0,0 +1,5 @@
+---
+'@qwik.dev/core': patch
+---
+
+fix: keep sibling updates running after uncaught render errors

packages/qwik/src/core/client/dom-container.ts

@@ -285,7 +285,8 @@ export class DomContainer extends _SharedContainer implements IClientContainer {
     if (!__EXPERIMENTAL__.errorBoundary) {
       const errorStore = host && this.resolveContext(host, ERROR_CONTEXT);
       if (!errorStore) {
-        throw err;
+        logErrorAndThrowAsync(err);
+        return;
       }
       errorStore.error = err;
       return;

packages/qwik/src/core/tests/error-handling.spec.tsx

@@ -0,0 +1,36 @@
+import { component$, useSignal, type Signal } from '@qwik.dev/core';
+import { domRender, ssrRenderToDom, trigger } from '@qwik.dev/core/testing';
+import { describe, expect, it } from 'vitest';
+
+describe.each([
+  { render: ssrRenderToDom }, //
+  { render: domRender }, //
+])('$render.name: error handling', ({ render }) => {
+  it('keeps updating a sibling after an uncaught client render error', async () => {
+    const Crasher = component$(() => {
+      throw new Error('boom');
+    });
+
+    const Counter = component$<{ count: Signal<number> }>(({ count }) => (
+      <button onClick$={() => count.value++}>{count.value}</button>
+    ));
+
+    const App = component$(() => {
+      const count = useSignal(0);
+      return (
+        <>
+          <Counter count={count} />
+          {count.value === 1 && <Crasher />}
+        </>
+      );
+    });
+
+    const { container } = await render(<App />);
+    const button = container.element.querySelector('button')!;
+
+    expect(button.textContent).toBe('0');
+    await trigger(container.element, button, 'click', {}, { waitForIdle: false });
+    await trigger(container.element, button, 'click', {}, { waitForIdle: false });
+    expect(button.textContent).toBe('2');
+  });
+});