fix(desktop-shell): address review findings for brand builder skill

- Add brand-builds/ to .gitignore (R1-19)
- Validate logo is a file, not a directory (R1-8)
- Document target-specific bundle path in SKILL.md (R1-17)

Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>

Author: yiliang114

.gitignore

@@ -139,3 +139,6 @@ tmp/
 # Auto-generated computer-use marker can also appear under nested packages.
 **/.qwen/computer-use/
 .playwright-mcp/
+
+# Brand build workspaces (created by the desktop-brand-builder skill)
+brand-builds/

packages/desktop-shell/.agents/skills/desktop-brand-builder/SKILL.md

@@ -143,7 +143,9 @@ npx tauri build --target aarch64-apple-darwin   # explicit macOS arm64
 
 For `target: all`, run only targets supported by the current machine or CI
 environment. Do not claim cross-platform artifacts were produced unless the
-files exist. Artifacts land under `packages/desktop-shell/src-tauri/target/release/bundle/`.
+files exist. Artifacts land under `packages/desktop-shell/src-tauri/target/release/bundle/`
+for the host target, or `src-tauri/target/<triple>/release/bundle/` when
+`--target <triple>` is used.
 
 ## Signing and Updates
 
@@ -159,6 +161,7 @@ After packaging:
 
 1. Confirm the expected artifact exists under
    `packages/desktop-shell/src-tauri/target/release/bundle/`
+   (or `src-tauri/target/<triple>/release/bundle/` for cross-compile targets)
    (`dmg/`, `nsis/`, `appimage/`, or `deb/`).
 2. Compute `sha256sum` or `shasum -a 256` for each artifact.
 3. On macOS, run `hdiutil verify` for generated DMG files.

packages/desktop-shell/.agents/skills/desktop-brand-builder/scripts/brand-create.mjs

@@ -14,7 +14,7 @@
  */
 
 import { spawnSync } from 'node:child_process';
-import { copyFileSync, existsSync, readFileSync, writeFileSync } from 'node:fs';
+import { copyFileSync, existsSync, readFileSync, statSync, writeFileSync } from 'node:fs';
 import { extname, join, resolve } from 'node:path';
 
 const BRAND_ID_RE = /^[a-z][a-z0-9-]*$/;
@@ -85,7 +85,7 @@ function loadConfig(path) {
   if (!brandId || !BRAND_ID_RE.test(brandId)) {
     fail(`brandId must match ${BRAND_ID_RE}`);
   }
-  if (!logo || !existsSync(logo)) {
+  if (!logo || !existsSync(logo) || !statSync(logo).isFile()) {
     fail(`logo must be an existing file path, got: ${input.logo}`);
   }