Skip to content

Commit 96c6987

Browse files
doudouOUCqwencoder
andcommitted
codex: address PR review feedback (#6013)
Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
1 parent 947823d commit 96c6987

1 file changed

Lines changed: 16 additions & 4 deletions

File tree

packages/cli/src/serve/run-qwen-serve.test.ts

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -773,9 +773,11 @@ describe('runQwenServe runtime startup failures', () => {
773773
telemetryPromise,
774774
);
775775
const bridge = makeRuntimeBridge();
776-
vi.spyOn(acpBridge, 'createAcpSessionBridge').mockReturnValue(
777-
bridge as ReturnType<typeof acpBridge.createAcpSessionBridge>,
778-
);
776+
const createBridge = vi
777+
.spyOn(acpBridge, 'createAcpSessionBridge')
778+
.mockReturnValue(
779+
bridge as ReturnType<typeof acpBridge.createAcpSessionBridge>,
780+
);
779781

780782
const handle = await runQwenServe(
781783
{
@@ -789,15 +791,25 @@ describe('runQwenServe runtime startup failures', () => {
789791
{
790792
resolveOnListen: true,
791793
deferRuntimeUntilFirstHealth: true,
792-
runtimeStartupTimeoutMs: 1,
794+
runtimeStartupTimeoutMs: 0,
793795
},
794796
);
795797

796798
try {
797799
await new Promise((resolve) => setTimeout(resolve, 25));
800+
expect(createBridge).not.toHaveBeenCalled();
798801
const healthRes = await fetch(`${handle.url}/health`);
799802
expect(healthRes.status).toBe(200);
800803
expect(await healthRes.json()).toEqual({ status: 'ok' });
804+
805+
resolveTelemetry?.({
806+
enabled: false,
807+
sensitiveSpanAttributeMaxLength: 1024 * 1024,
808+
});
809+
await vi.waitFor(() => expect(createBridge).toHaveBeenCalledTimes(1), {
810+
timeout: 1500,
811+
});
812+
await expect(handle.runtimeReady).resolves.toBeUndefined();
801813
} finally {
802814
resolveTelemetry?.({
803815
enabled: false,

0 commit comments

Comments
 (0)