Skip to content

Commit 8fd0162

Browse files
authored
fix(release): normalize Live Host signing identity (#8579)
1 parent 89b3d5e commit 8fd0162

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

.github/workflows/live-host-release.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,8 +148,9 @@ jobs:
148148
security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k "$keychain_password" "$keychain"
149149
identity="$(security find-identity -v -p codesigning "$keychain" | sed -n 's/.*"\(Developer ID Application:.*\)"/\1/p' | head -n 1)"
150150
if [ -z "$identity" ]; then echo '::error::Developer ID Application identity was not found.'; exit 1; fi
151+
identity_name="${identity#Developer ID Application: }"
151152
{
152-
echo "CSC_NAME=$identity"
153+
echo "CSC_NAME=$identity_name"
153154
echo 'CSC_IDENTITY_AUTO_DISCOVERY=true'
154155
} >> "$GITHUB_ENV"
155156

scripts/tests/release-workflow.test.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -115,6 +115,11 @@ describe('Live Host release workflow', () => {
115115
expect(liveHostReleaseWorkflow).toContain(
116116
'echo "APPLE_API_KEY_ID=$api_key_id"',
117117
);
118+
expect(liveHostReleaseWorkflow).toContain(
119+
'identity_name="${identity#Developer ID Application: }"',
120+
);
121+
expect(liveHostReleaseWorkflow).toContain('echo "CSC_NAME=$identity_name"');
122+
expect(liveHostReleaseWorkflow).not.toContain('echo "CSC_NAME=$identity"');
118123
});
119124
});
120125

0 commit comments

Comments
 (0)