test(core): isolate session recap side query mock

Author: Jerry2003826

packages/core/src/services/sessionRecap.test.ts

@@ -5,65 +5,57 @@
  */
 
 import type { Content } from '@google/genai';
-import { mkdtemp, rm, writeFile } from 'node:fs/promises';
-import { tmpdir } from 'node:os';
-import { join } from 'node:path';
-import { afterEach, describe, expect, it, vi } from 'vitest';
+import { beforeEach, describe, expect, it, vi } from 'vitest';
 import type { Config } from '../config/config.js';
-import { generateSessionRecap } from './sessionRecap.js';
 
-describe('generateSessionRecap', () => {
-  let tempDir: string | undefined;
+const runSideQueryMock = vi.hoisted(() => vi.fn());
+
+vi.mock('../utils/sideQuery.js', () => ({
+  runSideQuery: runSideQueryMock,
+}));
 
-  afterEach(async () => {
-    if (tempDir) {
-      await rm(tempDir, { recursive: true, force: true });
-      tempDir = undefined;
-    }
+describe('generateSessionRecap', () => {
+  beforeEach(() => {
+    vi.resetModules();
+    runSideQueryMock.mockReset();
   });
 
   it('opts into the configured output language preference for recap prompts', async () => {
-    tempDir = await mkdtemp(join(tmpdir(), 'qwen-session-recap-'));
-    const outputLanguagePath = join(tempDir, 'output-language.md');
-    await writeFile(outputLanguagePath, 'Always answer in Chinese.\n');
-
     const history: Content[] = [
       { role: 'user', parts: [{ text: 'fix the failing auth test' }] },
       { role: 'model', parts: [{ text: 'I found the mocked token issue.' }] },
     ];
-    const generateText = vi.fn().mockResolvedValue({
+    runSideQueryMock.mockResolvedValue({
       text: '<recap>Auth test fix is in progress.</recap>',
       usage: undefined,
     });
     const config = {
       getGeminiClient: vi.fn(() => ({
         getChat: () => ({ getHistory: () => history }),
       })),
-      getBaseLlmClient: vi.fn(() => ({ generateText })),
-      getModel: vi.fn(() => 'qwen3-coder-plus'),
-      getOutputLanguageFilePath: vi.fn(() => outputLanguagePath),
     } as unknown as Config;
+    const abortSignal = new AbortController().signal;
+    const { generateSessionRecap } = await import('./sessionRecap.js');
 
-    const result = await generateSessionRecap(
-      config,
-      new AbortController().signal,
-    );
+    const result = await generateSessionRecap(config, abortSignal);
 
     expect(result).toBe('Auth test fix is in progress.');
-    expect(generateText).toHaveBeenCalledWith(
+    expect(runSideQueryMock).toHaveBeenCalledWith(
+      config,
       expect.objectContaining({
+        purpose: 'session-recap',
+        respectOutputLanguagePreference: true,
         systemInstruction: expect.stringContaining(
           'You generate session recaps',
         ),
-        promptId: 'side-query:session-recap',
         maxAttempts: 1,
+        abortSignal,
       }),
     );
-    expect(generateText).toHaveBeenCalledWith(
+    expect(runSideQueryMock).toHaveBeenCalledWith(
+      config,
       expect.objectContaining({
-        systemInstruction: expect.stringContaining(
-          'User output language preference from output-language.md:\nAlways answer in Chinese.',
-        ),
+        contents: expect.arrayContaining(history),
       }),
     );
   });