Skip to content

Commit b74342c

Browse files
akprasadanrflamary
andauthored
[MRG] Fix documentation for lowrank_sinkhorn and lowrank_gromov_wasserstein… (#823)
* Fix documentation for lowrank_sinkhorn and lowrank_gromov_wasserstein_samples. * Update RELEASES.md Add docstring fix to RELEASES.MD --------- Co-authored-by: Rémi Flamary <remi.flamary@gmail.com>
1 parent 2467702 commit b74342c

3 files changed

Lines changed: 8 additions & 7 deletions

File tree

RELEASES.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ This new release adds support for sparse cost matrices and a new lazy EMD solver
3232
implemented in `ot.sgot` (PR #792)
3333
- Add batch FUGW loss to `ot.batch` and fix issues in some default parameters in the batch module (PR #775)
3434
- Build wheels on ubuntu ARM to avoid QEMU emulation (PR #818)
35-
- Add new methods to compute the linear transport map and the related 2-Wasserstein distance betweeen high-dimensional (HD) Gaussian distributions as described in [88], implemented in `ot.gaussian.bures_wasserstein_mapping_hd` and `ot.gaussian.bures_wasserstein_distance_hd`, respectively. Two additional methods estimate the same quantities from the source and destination observed data and are implemented in `ot.gaussian.empirical_bures_wasserstein_mapping_hd` and `ot.gaussian.empirical_bures_wasserstein_distance_hd`, respectively (PR #814)
35+
- Add new methods to compute the linear transport map and the related 2-Wasserstein distance betweeen high-dimensional (HD) Gaussian distributions as described in [88], implemented in `ot.gaussian.bures_wasserstein_mapping_hd` and `ot.gaussian.bures_wasserstein_distance_hd`, respectively. Two additional methods estimate the same quantities from the source and destination observed data and are implemented in `ot.gaussian.empirical_bures_wasserstein_mapping_hd` and `ot.gaussian.empirical_bures_wasserstein_distance_hd`, respectively (PR #814)
36+
- Fix docstrings for `lowrank_gromov_wasserstein_samples` and `lowrank_sinkhorn` (PR #823)
3637

3738

3839
#### Closed issues

ot/gromov/_lowrank.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ def lowrank_gromov_wasserstein_samples(
9393
where :
9494
9595
- :math:`A` is the (`dim_a`, `dim_a`) square pairwise cost matrix of the source domain.
96-
- :math:`B` is the (`dim_a`, `dim_a`) square pairwise cost matrix of the target domain.
96+
- :math:`B` is the (`dim_b`, `dim_b`) square pairwise cost matrix of the target domain.
9797
- :math:`\mathcal{Q}_{A,B}` is quadratic objective function of the Gromov Wasserstein plan.
9898
- :math:`Q` and `R` are the low-rank matrix decomposition of the Gromov-Wasserstein plan.
9999
- :math:`g` is the weight vector for the low-rank decomposition of the Gromov-Wasserstein plan.
@@ -119,9 +119,9 @@ def lowrank_gromov_wasserstein_samples(
119119
Regularization term >=0
120120
rank : int, optional. Default is None. (>0)
121121
Nonnegative rank of the OT plan. If None, min(ns, nt) is considered.
122-
alpha : int, optional. Default is 1e-10. (>0 and <1/r)
122+
alpha : float, optional. Default is 1e-10. (>0 and <1/r)
123123
Lower bound for the weight vector g.
124-
rescale_cost : bool, optional. Default is False
124+
rescale_cost : bool, optional. Default is True
125125
Rescale the low rank factorization of the sqeuclidean cost matrix
126126
seed_init : int, optional. Default is 49. (>0)
127127
Random state for the 'random' initialization of low rank couplings
@@ -135,9 +135,9 @@ def lowrank_gromov_wasserstein_samples(
135135
Stop threshold on error (>0) for Low Rank GW
136136
The error is the sum of Kullback Divergences computed for each low rank
137137
coupling (Q, R and g) and scaled using gamma.
138-
numItermax_dykstra : int, optional. Default is 2000.
138+
numItermax_dykstra : int, optional. Default is 10000.
139139
Max number of iterations for the Dykstra algorithm
140-
stopThr_dykstra : float, optional. Default is 1e-7.
140+
stopThr_dykstra : float, optional. Default is 1e-3.
141141
Stop threshold on error (>0) in Dykstra
142142
cost_factorized_Xs: tuple, optional. Default is None
143143
Tuple with two pre-computed low rank decompositions (A1, A2) of the source cost

ot/lowrank.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -374,7 +374,7 @@ def lowrank_sinkhorn(
374374
Nonnegative rank of the OT plan. If None, min(ns, nt) is considered.
375375
alpha : int, optional. Default is 1e-10. (>0 and <1/r)
376376
Lower bound for the weight vector g.
377-
rescale_cost : bool, optional. Default is False
377+
rescale_cost : bool, optional. Default is True
378378
Rescale the low rank factorization of the sqeuclidean cost matrix
379379
init : str, optional. Default is 'random'.
380380
Initialization strategy for the low rank couplings. 'random', 'deterministic' or 'kmeans'

0 commit comments

Comments
 (0)