Fix metadata read (#2601)

* Add read only version of graph to allow python access
Add explicit flush for graph
Add fix for metadata in namespace

* tidy

* tidy

* Read only graph

* Test metadata

* chore: apply tidy-public auto-fixes

* Patch the cache

* read only index

* Adding tests for metadata segments

* added new tests

* chore: apply tidy-public auto-fixes

* Fixes for check metadata

* Function names

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Author: miratepuffin

db4-storage/src/api/edges.rs

@@ -6,7 +6,11 @@ use parking_lot::{RwLockReadGuard, RwLockWriteGuard, lock_api::ArcRwLockReadGuar
 use raphtory_api::core::entities::{
     LayerId,
     edges::edge_ref::Dir,
-    properties::{meta::Meta, prop::Prop, tprop::TPropOps},
+    properties::{
+        meta::Meta,
+        prop::{AsPropRef, Prop},
+        tprop::TPropOps,
+    },
 };
 use raphtory_core::{
     entities::{EID, LayerIds, VID, edges::edge_ref::EdgeRef},
@@ -118,6 +122,13 @@ pub trait EdgeSegmentOps: Send + Sync + std::fmt::Debug + 'static {
     fn immut_lsn(&self) -> LSN;
 
     fn flush(&self) -> Result<(), StorageError>;
+
+    fn check_metadata_immut<PR: AsPropRef>(
+        &self,
+        edge_pos: LocalPOS,
+        layer_id: LayerId,
+        props: &[(usize, PR)],
+    ) -> Result<(), StorageError>;
 }
 
 pub trait LockedESegment: Send + Sync + std::fmt::Debug {

db4-storage/src/api/graph_props.rs

@@ -1,6 +1,10 @@
 use crate::{error::StorageError, segments::graph_prop::segment::MemGraphPropSegment, wal::LSN};
 use parking_lot::{RwLockReadGuard, RwLockWriteGuard};
-use raphtory_api::core::entities::properties::{meta::Meta, prop::Prop, tprop::TPropOps};
+use raphtory_api::core::entities::properties::{
+    meta::Meta,
+    prop::{AsPropRef, Prop},
+    tprop::TPropOps,
+};
 use std::{fmt::Debug, path::Path, sync::Arc};
 
 pub trait GraphPropSegmentOps: Send + Sync + Debug + 'static
@@ -40,6 +44,11 @@ where
     ) -> Result<(), StorageError>;
 
     fn flush(&self) -> Result<(), StorageError>;
+
+    fn check_metadata_immut<PR: AsPropRef>(
+        &self,
+        props: &[(usize, PR)],
+    ) -> Result<(), StorageError>;
 }
 
 /// Trait for returning a guard-free, copyable reference to graph properties

db4-storage/src/api/nodes.rs

@@ -5,7 +5,7 @@ use raphtory_api::{
         Direction,
         entities::properties::{
             meta::{Meta, NODE_ID_IDX, NODE_TYPE_IDX},
-            prop::{Prop, PropUnwrap},
+            prop::{AsPropRef, Prop, PropUnwrap},
             tprop::TPropOps,
         },
     },
@@ -137,6 +137,13 @@ pub trait NodeSegmentOps: Send + Sync + Debug + 'static {
     fn num_layers(&self) -> usize;
 
     fn layer_count(&self, layer_id: LayerId) -> u32;
+
+    fn check_metadata_immut<P: AsPropRef>(
+        &self,
+        pos: LocalPOS,
+        layer_id: LayerId,
+        props: &[(usize, P)],
+    ) -> Result<(), StorageError>;
 }
 
 pub trait LockedNSSegment: Debug + Send + Sync {

db4-storage/src/pages/edge_page/writer.rs

@@ -195,7 +195,8 @@ impl<'a, MP: DerefMut<Target = MemEdgeSegment> + std::fmt::Debug, ES: EdgeSegmen
         layer_id: LayerId,
         props: &[(usize, P)],
     ) -> Result<(), StorageError> {
-        self.writer.check_metadata(edge_pos, layer_id, props)
+        self.writer.check_metadata(edge_pos, layer_id, props)?;
+        self.page.check_metadata_immut(edge_pos, layer_id, props)
     }
 
     pub fn update_c_props<P: AsPropRef>(

db4-storage/src/pages/graph_prop_page/writer.rs

@@ -43,7 +43,8 @@ impl<'a, GS: GraphPropSegmentOps> GraphPropWriter<'a, GS> {
     }
 
     pub fn check_metadata<P: AsPropRef>(&self, props: &[(usize, P)]) -> Result<(), StorageError> {
-        self.mem_segment.check_metadata(props)
+        self.mem_segment.check_metadata(props)?;
+        self.graph_props.check_metadata_immut(props)
     }
 
     pub fn set_lsn(&mut self, lsn: LSN) {

db4-storage/src/pages/node_page/writer.rs

@@ -166,7 +166,8 @@ impl<'a, MP: DerefMut<Target = MemNodeSegment> + 'a, NS: NodeSegmentOps> NodeWri
         layer_id: LayerId,
         props: &[(usize, P)],
     ) -> Result<(), StorageError> {
-        self.mut_segment.check_metadata(pos, layer_id, props)
+        self.mut_segment.check_metadata(pos, layer_id, props)?;
+        self.page.check_metadata_immut(pos, layer_id, props)
     }
 
     pub fn update_c_props<P: AsPropRef>(

db4-storage/src/segments/edge/segment.rs

@@ -615,6 +615,15 @@ impl<P: PersistenceStrategy<ES = EdgeSegmentView<P>>> EdgeSegmentOps for EdgeSeg
     fn flush(&self) -> Result<(), StorageError> {
         Ok(())
     }
+
+    fn check_metadata_immut<PR: AsPropRef>(
+        &self,
+        _edge_pos: LocalPOS,
+        _layer_id: LayerId,
+        _props: &[(usize, PR)],
+    ) -> Result<(), StorageError> {
+        Ok(())
+    }
 }
 
 #[cfg(test)]

db4-storage/src/segments/graph_prop/mod.rs

@@ -9,7 +9,7 @@ use crate::{
     wal::LSN,
 };
 use parking_lot::{RwLock, RwLockReadGuard, RwLockWriteGuard};
-use raphtory_api::core::entities::properties::meta::Meta;
+use raphtory_api::core::entities::properties::{meta::Meta, prop::AsPropRef};
 use std::{
     path::Path,
     sync::{
@@ -98,4 +98,11 @@ impl<P: PersistenceStrategy> GraphPropSegmentOps for GraphPropSegmentView<P> {
     fn flush(&self) -> Result<(), StorageError> {
         Ok(())
     }
+
+    fn check_metadata_immut<PR: AsPropRef>(
+        &self,
+        _props: &[(usize, PR)],
+    ) -> Result<(), StorageError> {
+        Ok(())
+    }
 }

db4-storage/src/segments/node/segment.rs

@@ -601,6 +601,15 @@ impl<P: PersistenceStrategy<NS = NodeSegmentView<P>>> NodeSegmentOps for NodeSeg
             .get_layer(layer_id)
             .map_or(0, |layer| layer.len())
     }
+
+    fn check_metadata_immut<PR: AsPropRef>(
+        &self,
+        _pos: LocalPOS,
+        _layer_id: LayerId,
+        _props: &[(usize, PR)],
+    ) -> Result<(), StorageError> {
+        Ok(())
+    }
 }
 
 #[cfg(test)]