Skip to content

Move HooksController to use MongoCollection instead of direct Mongo access. - #844

Merged
nlutsenko merged 1 commit into
masterfrom
nlutsenko.hooks
Mar 7, 2016
Merged

Move HooksController to use MongoCollection instead of direct Mongo access.#844
nlutsenko merged 1 commit into
masterfrom
nlutsenko.hooks

Conversation

@nlutsenko

Copy link
Copy Markdown
Contributor

No description provided.

@codecov-io

Copy link
Copy Markdown

Current coverage is 91.69%

Merging #844 into master will increase coverage by +0.01% as of 2c3f278

@@            master    #844   diff @@
======================================
  Files           71      71       
  Stmts         4100    4092     -8
  Branches       843     844     +1
  Methods          0       0       
======================================
- Hit           3759    3752     -7
  Partial         10      10       
+ Missed         331     330     -1

Review entire Coverage Diff as of 2c3f278

Powered by Codecov. Updated on successful CI builds.

for(var i in req) {
return (req, res) => {
let jsonBody = {};
for (var i in req) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a bug here, should be req.body no?

we could use deepcopy instead, or let jsonBody = Object.assign({}, req.body);

nlutsenko added a commit that referenced this pull request Mar 7, 2016
Move HooksController to use MongoCollection instead of direct Mongo access.
@nlutsenko
nlutsenko merged commit f1f9bde into master Mar 7, 2016
@nlutsenko
nlutsenko deleted the nlutsenko.hooks branch March 7, 2016 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants